Fix InkWell ripple visible on right click when not expected #124386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: material design
Renzo-Olivares
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
This LGTM thanks for fixing this!
In regards to not having the splash show when a pop up menu is activated by the secondary button I think I would still expect some visual indication that the button has been tapped. I don't see a reason why this should not be customizable though.
justinmc
approved these changes
Apr 7, 2023
Comment on lines
1235
to
1236
| bool get primaryButtonEnabled => _primaryButtonEnabled(widget); | ||
| bool get secondaryButtonEnabled => _secondaryButtonEnabled(widget); |
There was a problem hiding this comment.
What's the reason for making these public? I'm not against it I just want to make sure we don't expose new APIs that could be private.
There was a problem hiding this comment.
I think there is no good reason and that these accessors should be private, good catch!
I have updated the PR accordingly.
bleroux
force-pushed
the
fix_ink_well_ripple_on_secondary_tap
branch
from
d9455ea
to
7c4ac9d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 8, 2023
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…124386) Right clicking an InkWell with no secondary tap handlers will no longer cause a ripple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the splash effect when no secondary button callbacks are defined.
InkWelldefines several useful callbacks related to the secondary button.When no secondary button callbacks are defined the splash effect should not be visible.
Implementation choice
This PR does not remove the splash effect when at least one of the secondary button callbacks is defined (this behavior was proposed in #119058 (review)).
Maybe we should consider if showing a splash effect for the secondary button is an expected behavior (and decide to remove it or make it configurable) ? A possible use case is an InkWell which defines both primary button callbacks and secondary button callbacks, where the primary button is used to execute an action and the secondary button to show a popup menu, in this case, it might be a better UX choice to not show the splash effect for the secondary button.
@Renzo-Olivares @justinmc
Related Issue
Fixes #124328
Tests
Adds 1 test.