Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland Refactor reorderable list semantics #124395

Merged
merged 1 commit into from Apr 7, 2023
Merged

Reland Refactor reorderable list semantics #124395

merged 1 commit into from Apr 7, 2023

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Apr 7, 2023

Previous pr was reverted due to internal customer extends the materialLocalization with a special english translation for a certain ethnic group

This pr revert the localization breaking change so that the internal customer can migrate

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 7, 2023
@chunhtai chunhtai mentioned this pull request Apr 7, 2023
Closed
Piinks
Piinks approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reland LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2023
@auto-submit auto-submit bot merged commit e5e765e into flutter:master Apr 7, 2023
71 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2023
@engine-flutter-autoroll
e5e765e68 Reland Refactor reorderable list semantics (flutter/flutter…
41fd92f 
…#124395)
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@chunhtai @exaby73
Reland Refactor reorderable list semantics (flutter#124395)
6f7b766 
Reland Refactor reorderable list semantics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chunhtai @Piinks