New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debounce the proxied connection over proxied devices. #124540
Conversation
This improves performance when there are many small packets being sent, especially when attaching a debugger.
expect(source.hasListener, true); | ||
}); | ||
|
||
testWithoutContext('forwards data normally is all data is longer than duration apart', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testWithoutContext('forwards data normally is all data is longer than duration apart', () { | |
testWithoutContext('forwards data normally if all data is longer than duration apart', () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for the very clear easy to read tests! I always struggle testing anything async...
Debounce the proxied connection over proxied devices.
This improves performance when there are many small packets being sent, especially when attaching a debugger.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.