Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BottomAppBar doc: Fix doc about surfaceTintColor #124563

Merged
merged 1 commit into from Apr 20, 2023
Merged

BottomAppBar doc: Fix doc about surfaceTintColor #124563

merged 1 commit into from Apr 20, 2023

Conversation

chrisbobbe
Copy link
Contributor

Fixes #124535
Fixes #124536

The new text mentions that surfaceTintColor is ignored in Material 2 (fixing #124536) and correctly says what the surface tint color will be when surfaceTintColor is null, fixing #124535.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 11, 2023
HansMuller
HansMuller approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 58e3085 into flutter:master Apr 20, 2023
71 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
92234a2 
…lutter#124563)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
c6e6dc6 
…lutter#124563)
@chrisbobbe chrisbobbe deleted the pr-bottom-app-bar-surface-tint-color-doc branch April 21, 2023 20:34
@chrisbobbe
Copy link
Contributor Author

Thanks for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
e37e084 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
2b59985 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
56d986a 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
2c30a46 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
b5688ef 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
55d21e8 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
5b696c5 
…lutter#124563)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
e33c6e9 
…lutter#124563)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
60122c4 
…lutter#124563)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
58e30852e BottomAppBar doc: Fix doc about surfaceTintColor (flutter/f…
fa4a02c 
…lutter#124563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
2 participants
@chrisbobbe @HansMuller