Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter_tools: Flutter Web CLI cleanup #124564

Merged
merged 3 commits into from Apr 12, 2023
Merged

flutter_tools: Flutter Web CLI cleanup #124564

merged 3 commits into from Apr 12, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 11, 2023

Eliminate map that's redundant with enum values
Use enhanced enum and extention features

@kevmoo
flutter_tools: Flutter Web CLI cleanup
39dd375 
Eliminate map that's redundant with enum values
Use enhanced enum and extention features
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 11, 2023
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 11, 2023

PTAL @ditman

ditman
ditman approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Look at all those get foo => switch(this)..., damn! Sweet, sweet syntax sugar!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit auto-submit bot merged commit 895879c into master Apr 12, 2023
124 checks passed
@auto-submit auto-submit bot deleted the web_enum_silly branch April 12, 2023 00:01
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
895879c19 flutter_tools: Flutter Web CLI cleanup (flutter/flutter#124564
b0acf51 
)
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
@kevmoo @exaby73
flutter_tools: Flutter Web CLI cleanup (flutter#124564)
cbf1493 
flutter_tools: Flutter Web CLI cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ditman ditman ditman approved these changes

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevmoo @ditman