New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of deprecated test_api imports #124732
Conversation
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files. Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.
@@ -4,7 +4,7 @@ | |||
|
|||
import 'dart:typed_data'; | |||
|
|||
import 'package:test_api/src/expect/async_matcher.dart'; // ignore: implementation_imports | |||
import 'package:matcher/src/expect/async_matcher.dart'; // ignore: implementation_imports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, why is this one not part of the public API of package:matcher? Could it be? Seems like we are using it in a lot of places...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own understanding, why is this one not part of the public API of package:matcher?
AsyncMatcher was originally a hack in package:test
. It's not a very easy class to use, and it's behavior is contradictory to the rest of package:matcher
.
Could it be?
Now that is has been moved into package:matcher
it would be a little less strange to expose it. I'd still be a bit wary to do so, since we don't want to spend effort on things like improving the documentation and compatibility with AsyncMatcher.
I think a better use of time is to focus on the transition to package:checks
where async checks are fully supported.
(I restarted all the failing checks, they were failing due to a pub outage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tool side LGTM
auto label is removed for flutter/flutter, pr: 124732, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
I created a CL with the required deps changes. Once it has an LGTM I'll add it in FRoB and it should fix Google testing. |
@natebosch just following up to let you know Google testing seems to be stuck, updating the branch may kickstart it again? |
Most of these imports were never appropriate. The
test_api
package was never intended for use in_test.dart
files.Where possible move imports to
matcher
, otherwise move them totest
orflutter_test
.Leave uses of
test_api
fromflutter_test
library code.