Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter-tool: enum cleanup #124760

Merged
merged 15 commits into from
Apr 14, 2023
Merged

flutter-tool: enum cleanup #124760

merged 15 commits into from
Apr 14, 2023

Commits on Apr 13, 2023

  1. flutter-tool: enum cleanup 

    Made BuildMode an enum. Inlined a number of helpers
Inlined associted helpers into FlutterProjectType, ServiceWorkerStrategy, and Browser enums
  Updated associated CLI code to use helpers

Removed very outdated enum helpers

Migrated a few places to use switch expressions
Migrated one type to `abstract final` with only static members

Updated buildWeb command to take ServiceWorkerStrategy over String
  (nice to have this type-safe)
    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    d6691c7 View commit details
    Browse the repository at this point in the history

  2. oops

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    7bd66f4 View commit details
    Browse the repository at this point in the history

  3. oops2

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a7fafc7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into cli_cleanup_silly

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0e9bc7a View commit details
    Browse the repository at this point in the history

  5. whitespace

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    121f481 View commit details
    Browse the repository at this point in the history

  6. oops3

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    34b4e09 View commit details
    Browse the repository at this point in the history

  7. oops4

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    20ffa00 View commit details
    Browse the repository at this point in the history

  8. oops5

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b75e40d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into cli_cleanup_silly

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    95b335a View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into cli_cleanup_silly

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0bc6c29 View commit details
    Browse the repository at this point in the history

  11. one more snake

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    546a1f7 View commit details
    Browse the repository at this point in the history

  12. for david

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8da64e5 View commit details
    Browse the repository at this point in the history

  13. one more thing

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    8c80618 View commit details
    Browse the repository at this point in the history

  14. Update packages/flutter_tools/lib/src/drive/web_driver_service.dart

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    751c163 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'master' into cli_cleanup_silly

    @kevmoo
    kevmoo committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    829c9bc View commit details
    Browse the repository at this point in the history