Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust selection rects inclusion criteria #125022

Merged
merged 3 commits into from Apr 22, 2023
Merged

Adjust selection rects inclusion criteria #125022

merged 3 commits into from Apr 22, 2023

Conversation

moffatman
Copy link
Contributor

Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.

Part of #30476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Apr 18, 2023
@moffatman moffatman force-pushed the selection_rects_corners branch 3 times, most recently from 6dbfa84 to 6a430db Compare April 21, 2023 15:34
LongCatIsLooong
LongCatIsLooong approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this!

@moffatman
Adjust selection rects inclusion criteria
bd59e7b 
Include rects with any overlap instead of only when top-left or bottom-right included
@moffatman
Fix criteria
a478496
@moffatman
Reword comment
c85d878
@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2023
@auto-submit auto-submit bot merged commit e84daf3 into flutter:master Apr 22, 2023
71 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
dd9a6d0 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
d20c6d3 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
b7d0035 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
55a93c1 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
207ea55 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
7870014 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
05d5427 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
61c4dc2 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
47e9eb1 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
ef47d05 
…125022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
5e429b3 
…125022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
ec14d63 
…125022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
3f4e124 
…125022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3b7 Adjust selection rects inclusion criteria (flutter/flutter#…
ce99c59 
…125022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellohuanlin hellohuanlin hellohuanlin left review comments

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moffatman @LongCatIsLooong @hellohuanlin