Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reland] Update helper message for --suppress-analytics #125145

Merged
merged 9 commits into from Apr 19, 2023
Merged

[reland] Update helper message for --suppress-analytics #125145

merged 9 commits into from Apr 19, 2023

Conversation

eliasyishak
Copy link
Contributor

Relanding: #124810

Fixes: #124808

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 19, 2023
zanderso
zanderso approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reland lgtm this change was not the cause of the tree closure.

@eliasyishak eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
@auto-submit auto-submit bot merged commit ca3a900 into flutter:master Apr 19, 2023
123 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
6e569f4 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
5f5f254 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
84b9a0b 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
57ce597 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
ccb7866 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
bc0ae8e 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
b0d56be 
…lutter/flutter#125145)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
cc56ad2 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
8106ed6 
…lutter/flutter#125145)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
8b286f5 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
3503420 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
2dda727 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
581ed0a 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
d1f58a6 
…lutter/flutter#125145)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
b4581c6 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
02284b1 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
e1a7ffd 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
d13d176 
…lutter/flutter#125145)
@eliasyishak eliasyishak deleted the 124808-clean-up-help-messages-for-disabling-and-suppressing-analytics branch April 24, 2023 21:59
eliasyishak added a commit to eliasyishak/flutter that referenced this pull request Apr 24, 2023
@eliasyishak
[reland] Update helper message for --suppress-analytics (flutter#12…
6f45d9b 
…5145)

Relanding: flutter#124810

Fixes: flutter#124808
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
300525b 
…lutter/flutter#125145)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
ca3a900d5 [reland] Update helper message for --suppress-analytics (f…
5f1ba5e 
…lutter/flutter#125145)
@eliasyishak eliasyishak mentioned this pull request May 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up help messages for disabling and suppressing analytics
2 participants
@eliasyishak @zanderso