Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search view shape should clip the view content #125161

Merged
merged 1 commit into from Apr 20, 2023
Merged

Search view shape should clip the view content #125161

merged 1 commit into from Apr 20, 2023

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Apr 19, 2023 •
edited

Fixes #124426

This PR is to make the search view shape clip the view content.

Before: the highlight and the "i" of "item 9" are not clipped by the shape.

Screenshot 2023-04-19 at 12 09 48 PM

After:

Screenshot 2023-04-19 at 2 13 52 PM

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review April 19, 2023 21:16
HansMuller
HansMuller approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023
@auto-submit auto-submit bot merged commit 3315b25 into flutter:master Apr 20, 2023
71 checks passed
@QuncCccccc QuncCccccc changed the title Make search view shape clip the view content Search view shape should clip the view content Apr 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
c85c0b7 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
8de8e87 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
4bc0284 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
1290bc0 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
4726e07 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
895f06c 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
c1e1ec4 
…er#125161)
This was referenced Apr 20, 2023
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
3a112fb 
…er#125161)
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
aaff4b6 
…er#125161)
@reidbaker reidbaker mentioned this pull request Apr 21, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
7ddd903 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
1a1fbb0 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
38069d5 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
c686470 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
541dfc1 
…er#125161)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
22a665f 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
9542e86 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
ad861f0 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
30fafa8 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
6e58b6c 
…er#125161)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
3315b2574 Make search view shape clip the view content (flutter/flutt…
22ed795 
…er#125161)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The view shape of SearchAnchor is not clipping view's content
2 participants
@QuncCccccc @HansMuller