Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SnackBar material clip #125622

Merged
merged 1 commit into from Apr 27, 2023
Merged

Fix SnackBar material clip #125622

merged 1 commit into from Apr 27, 2023

Conversation

TahaTesser
Copy link
Member

fixes #125619

Before

Screenshot 2023-04-27 at 14 08 05

After

Screenshot 2023-04-27 at 14 00 44

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 27, 2023
@TahaTesser TahaTesser requested a review from Piinks April 27, 2023 11:50
HansMuller
HansMuller approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@auto-submit auto-submit bot merged commit 18e36dc into flutter:master Apr 27, 2023
69 checks passed
@TahaTesser TahaTesser deleted the fix_snackbar_material_clip branch April 27, 2023 21:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
4cfd8ff
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
ab67c09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
a930401
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
8a432d7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
10772f7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
c9ad859
@HansMuller HansMuller mentioned this pull request Apr 28, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
4ae4bbe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
0a793f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
bd60d86
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
5506d1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
573cf5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
f18b0b3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
ea0c501
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
feb7387
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
e413ebb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
531d6a3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
5cf5609
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
9d87e30
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
fcda80b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
71d9896
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
207f4d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
18e36dcb5 Fix SnackBar material clip (flutter/flutter#125622)
d5cafbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

@Piinks Piinks Awaiting requested review from Piinks

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SnackBar clipBehavior is not behaving
2 participants
@TahaTesser @HansMuller