-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reland] Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected #125836
Merged
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2c2951a
Revert "Revert "Add migrator to upgrade gradle version when conflict …
c13f369
adding a check for null android studio version and wrapping migrate c…
62ca35d
changing test to use target upgrade version constant
f1a1394
adding a test to cover catch block
190dd6f
changing FakeErroring test class to fix analyze warnings
b9956ad
making gradle version constant @visibleForTesting
8120c9c
adding last missed integration test
03d21ae
Revert "adding last missed integration test"
af0a939
adding missed integration test gradle wrapper
5e0a402
adding a check for null group even when groupcount is 1
32e2601
one more null check on regex groups
3220d86
catching errors in addition to exceptions
13c9b0f
Merge branch 'master' into reland_gradle_migrator
gmackall File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be annotated @VisibleForTesting