Fix nullability of ClipRRect.borderRadius #125878
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
f: cupertino
| case CupertinoListSectionType.base: | ||
| childrenGroupBorderRadius = BorderRadius.zero; | ||
| } | ||
| final BorderRadius childrenGroupBorderRadius = switch (type) { |
There was a problem hiding this comment.
I really like this new new from Dart 3. :)
|
test-exempt: code refactor with no semantic change |
goderbauer
force-pushed
the
fixNullabilityOfBorderRadious
branch
from
696e817
to
88c697b
Compare
The property was typed as nullable, but the code assumed its always non-null. This makes the property non-nullable as well.
Also refactors CupertinoListSection, which was flagged by the analyzer when borderRadius became non-nullable (no functional change, just cleaning up existing code to avoid the warning).