Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tool] consistently use environment (not globals) in targets/web.dart #125937

Merged
merged 7 commits into from May 4, 2023
Merged

[tool] consistently use environment (not globals) in targets/web.dart #125937

merged 7 commits into from May 4, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented May 3, 2023 •
edited

Also update the order of args to commands so that testing has less repeated "stuff"

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 3, 2023
@kevmoo kevmoo changed the base branch from master to kevmoo_tool_depfileservice May 3, 2023 03:33
Base automatically changed from kevmoo_tool_depfileservice to master May 3, 2023 20:54
@kevmoo kevmoo marked this pull request as ready for review May 3, 2023 22:52
@kevmoo kevmoo changed the title web build context [tool] consistently use environment (not globals) in targets/web.dart May 3, 2023
@kevmoo kevmoo added the platform-web Web applications specifically label May 3, 2023
@kevmoo kevmoo requested a review from yjbanov May 4, 2023 00:30
eyebrowsoffire
eyebrowsoffire approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter_tools/lib/src/build_system/targets/web.dart Outdated Show resolved Hide resolved
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label May 4, 2023
@auto-submit auto-submit bot merged commit 5816da8 into master May 4, 2023
121 checks passed
@auto-submit auto-submit bot deleted the web_build_context branch May 4, 2023 00:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
93ca713 
…s/web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
a766bf6 
…s/web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
faaa35b 
…s/web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
cd222ed 
…s/web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
476a56d 
…s/web.dart (flutter/flutter#125937)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
71ef167 
…s/web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
1b271bf 
…s/web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
8ceb014 
…s/web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
8137823 
…s/web.dart (flutter/flutter#125937)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5816da807 [tool] consistently use environment (not globals) in target…
af6b6b3 
…s/web.dart (flutter/flutter#125937)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevmoo @eyebrowsoffire