Clearer text about what happens with `--disable-telemetry` + enable-telemetry command #125995

eliasyishak · 2023-05-03T17:14:45Z

Fixes:

"Disable telemetry" refinements #124411

This PR is cleaning up the --disable-telemetry help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag --enable-telemetry which will enable telemetry collection

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

eliasyishak · 2023-05-04T17:00:23Z

packages/flutter_tools/test/general.shard/runner/runner_test.dart

-    final Usage legacyAnalytics = TestUsage();
-    setUp(() {
-      legacyAnalytics.enabled = false;
-    });
-


Wasn't being used anywhere in the tests, removing

packages/flutter_tools/lib/runner.dart

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart

eliasyishak · 2023-05-04T19:12:39Z

packages/flutter_tools/lib/runner.dart

+          throwToolExit(
+              'Both enable and disable telemetry commands were detected '
+              'when only one can be supplied per invocation.',
+              exitCode: 1);
+        }


Is an exit code of 1 appropriate for this exit code? @gspencergoog

Yes, I think so. Anything non-zero would work.

eliasyishak · 2023-05-05T15:04:02Z

@gspencergoog friendly ping, does this look good to go?

gspencergoog

…+ enable-telemetry command (flutter/flutter#125995)

flutter/flutter@43ac23b...4ed1c92 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265) 2023-05-08 42216813+eliasyishak@users.noreply.github.com Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262) 2023-05-08 goderbauer@google.com Fix leaks (flutter/flutter#126144) 2023-05-08 6655696+guidezpl@users.noreply.github.com Update packages (flutter/flutter#126140) 2023-05-06 pateltirth454@gmail.com [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195) 2023-05-06 linxunfeng@yeah.net [ios] fix hold and drag spacebar does not move cursor when obscureTexâ�¦ (flutter/flutter#122383) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188) 2023-05-06 github@alexv525.com â�¨ Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187) 2023-05-06 737941+loic-sharma@users.noreply.github.com Add Windows and Linux support to the 'layers' example (flutter/flutter#126105) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#3942) flutter/flutter@43ac23b...4ed1c92 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (flutter/flutter#126265) 2023-05-08 42216813+eliasyishak@users.noreply.github.com Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (flutter/flutter#125995) 2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (flutter/flutter#126262) 2023-05-08 goderbauer@google.com Fix leaks (flutter/flutter#126144) 2023-05-08 6655696+guidezpl@users.noreply.github.com Update packages (flutter/flutter#126140) 2023-05-06 pateltirth454@gmail.com [ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (flutter/flutter#123971) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (flutter/flutter#126199) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (flutter/flutter#126198) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (flutter/flutter#126195) 2023-05-06 linxunfeng@yeah.net [ios] fix hold and drag spacebar does not move cursor when obscureTexâ�¦ (flutter/flutter#122383) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (flutter/flutter#126192) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 332f53219c4c to d9116d94a111 (1 revision) (flutter/flutter#126190) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7c79b41b9d4 to 332f53219c4c (3 revisions) (flutter/flutter#126188) 2023-05-06 github@alexv525.com â�¨ Add `rect` argument to `_ArcPaintPredicate` for tests (flutter/flutter#125953) 2023-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 758cbadfac1f to b7c79b41b9d4 (4 revisions) (flutter/flutter#126187) 2023-05-06 737941+loic-sharma@users.noreply.github.com Add Windows and Linux support to the 'layers' example (flutter/flutter#126105) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…+ enable-telemetry command (flutter/flutter#125995)

Clearer text about what happens with --disable-telemetry

24631af

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 3, 2023

eliasyishak mentioned this pull request May 3, 2023

"Disable telemetry" refinements #124411

Closed

eliasyishak added 2 commits May 4, 2023 12:24

Adding flutter --enable-telemetry functionality + tests

d561ed2

Merge branch 'master' into 124411-disable-telemetry-refinements

a3d4d89

eliasyishak commented May 4, 2023

View reviewed changes

eliasyishak marked this pull request as ready for review May 4, 2023 17:07

eliasyishak requested a review from gspencergoog May 4, 2023 17:08

gspencergoog reviewed May 4, 2023

View reviewed changes

packages/flutter_tools/lib/runner.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart Outdated Show resolved Hide resolved

eliasyishak added 4 commits May 4, 2023 13:30

Lowercase for dart and flutter in help messages

d00778f

Removing bool value

dfb379b

Fix bug

0fdbf9d

Remove conditional on disabling telemetry

89555ae

gspencergoog reviewed May 4, 2023

View reviewed changes

packages/flutter_tools/lib/src/runner/flutter_command_runner.dart Show resolved Hide resolved

Throw if both enable and disable commands supplied + test

80ec41b

eliasyishak commented May 4, 2023

View reviewed changes

gspencergoog approved these changes May 5, 2023

View reviewed changes

eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label May 8, 2023

auto-submit bot merged commit 0d58752 into flutter:master May 8, 2023
122 checks passed

engine-flutter-autoroll mentioned this pull request May 8, 2023

Roll Flutter from 43ac23b4c7b4 to 4ed1c9230310 (16 revisions) flutter/packages#3942

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2023

0d5875274 Clearer text about what happens with --disable-telemetry …

3a16251

…+ enable-telemetry command (flutter/flutter#125995)

eliasyishak deleted the 124411-disable-telemetry-refinements branch May 8, 2023 17:06

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

0d5875274 Clearer text about what happens with --disable-telemetry …

5ac4115

…+ enable-telemetry command (flutter/flutter#125995)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0d5875274 Clearer text about what happens with --disable-telemetry …

938307a

…+ enable-telemetry command (flutter/flutter#125995)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0d5875274 Clearer text about what happens with --disable-telemetry …

377c9b5

…+ enable-telemetry command (flutter/flutter#125995)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

0d5875274 Clearer text about what happens with --disable-telemetry …

8d47966

…+ enable-telemetry command (flutter/flutter#125995)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clearer text about what happens with `--disable-telemetry` + enable-telemetry command #125995

Clearer text about what happens with `--disable-telemetry` + enable-telemetry command #125995

eliasyishak commented May 3, 2023 •

edited

eliasyishak May 4, 2023

eliasyishak May 4, 2023

gspencergoog May 4, 2023

eliasyishak commented May 5, 2023

gspencergoog left a comment

Clearer text about what happens with --disable-telemetry + enable-telemetry command #125995

Clearer text about what happens with --disable-telemetry + enable-telemetry command #125995

Conversation

eliasyishak commented May 3, 2023 • edited

Pre-launch Checklist

eliasyishak May 4, 2023

Choose a reason for hiding this comment

eliasyishak May 4, 2023

Choose a reason for hiding this comment

gspencergoog May 4, 2023

Choose a reason for hiding this comment

eliasyishak commented May 5, 2023

gspencergoog left a comment

Choose a reason for hiding this comment

Clearer text about what happens with `--disable-telemetry` + enable-telemetry command #125995

Clearer text about what happens with `--disable-telemetry` + enable-telemetry command #125995

eliasyishak commented May 3, 2023 •

edited