[web] Make HtmlElementView more useful #126176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
|
(triage) @mdebbar Do you still have plans for this draft? |
|
@goderbauer this was only a draft to discuss options, I think @mdebbar is actually going to land something different soon (should we fully close this PR so it doesn't uses resources during triage?) |
|
Yeah, we decided on a different plan here. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jun 2, 2023
In order to make `HtmlElementView` more useful, we need to expose an API for getting the created platform view element. ~~This would allow `HtmlElementView` to set attributes and styles on the element.~~ This would allow us to add a new callback to the `HtmlElementView` that would return the result of calling the registered platformViewFactory to the user, after it's been created and added to the DOM, so the user can do with it as they please. Required by flutter/flutter#126176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set html attributes and styles on the
HtmlElementViewwidget. This makes the widget much more convenient to use and avoids the registration of multiple view factories unnecessarily (e.g. pointer_interceptor).