Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spaces after flow control statements #126320

Merged
merged 24 commits into from May 15, 2023
Merged

Add spaces after flow control statements #126320

merged 24 commits into from May 15, 2023

Conversation

tgucio
Copy link
Contributor

@tgucio tgucio commented May 9, 2023 •
edited

This PR adds missing spaces after flow control statements (if, switch, for etc.) found in some *.dart and *.java files.

A check is also added in the analyzer.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 9, 2023
@bernaferrari
Copy link
Contributor

bernaferrari commented May 9, 2023 •
edited

Great work! I'm surprised there is not a lint that auto-catches this. cc @pq

@pq
Copy link
Contributor

pq commented May 9, 2023

yeah. This is a sticky one. As a general rule we don't have lints that report things that would be corrected by the formatter. In general this works fine but bites Flutter since you aren't using the formatter.

@tgucio
Copy link
Contributor Author

tgucio commented May 9, 2023 •
edited

Could be something for the analyzer (dev/bots/analyze.dart) I guess? /cc @Hixie

@Hixie
Copy link
Contributor

Hixie commented May 9, 2023

test-exempt: code refactor with no semantic change

But if you wanted to update dev/bots/analyze.dart to catch this that would be great! The trick is making sure there's no false positives.

Hixie
Hixie approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgucio
Copy link
Contributor Author

tgucio commented May 9, 2023

@Hixie I'll take a stab at adding a check in the analyzer then - I guess it's OK to include as part of this PR.

@tgucio tgucio changed the title Add spaces after if and switch statements Add spaces after flow control statements May 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
d2965fd 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
5bbe134 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
cbef987 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
a8e891c 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
5d61bdb 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
f40775a 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
9b9b599 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
8c9d13c 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
d8e11f9 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
86fa7b2 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
981b3fe 
…26320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
6fe7da0 
…26320)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@tgucio
Add spaces after flow control statements (flutter#126320)
bb6454e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
aacfc5e 
…26320)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
17b7d42 
…26320)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
8a39958 
…26320)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
99c7e9f08 Add spaces after flow control statements (flutter/flutter#1…
9e87afb 
…26320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgucio @bernaferrari @pq @Hixie