Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated comment #126927

Merged
merged 1 commit into from May 16, 2023
Merged

Remove outdated comment #126927

merged 1 commit into from May 16, 2023

Conversation

goderbauer
Copy link
Member

Follow-up to #126647 (comment).

@goderbauer goderbauer requested a review from Hixie May 16, 2023 16:30
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 16, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer mentioned this pull request May 16, 2023
Merged
@Hixie
Copy link
Contributor

Hixie commented May 16, 2023

test-exempt: removes comment

Hixie
Hixie approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 16, 2023

auto label is removed for flutter/flutter, pr: 126927, Mergeability of pull request flutter/flutter/126927 could not be determined at time of merge..

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit 1ca183d into master May 16, 2023
71 checks passed
@auto-submit auto-submit bot deleted the goderbauer-patch-1 branch May 16, 2023 17:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
e03d502
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
f15cb15
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@goderbauer
Remove outdated comment (flutter#126927)
19820a7 
Follow-up to flutter#126647 (comment).
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
5f2cfaa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
de0e1c4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
3cc215f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1ca183d55 Remove outdated comment (flutter/flutter#126927)
8d70fce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goderbauer @Hixie