Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to anticipate next Dart linter release #127211

Merged
merged 2 commits into from May 19, 2023
Merged

fixes to anticipate next Dart linter release #127211

merged 2 commits into from May 19, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented May 19, 2023 •
edited

The upcoming linter release notices null literals as unnecessary argument values and flags more type_literal_in_constant_pattern cases.

See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 19, 2023
@pq pq changed the title fixes for incoming linter fixes to anticipate next Dart linter release May 19, 2023
@pq pq requested a review from goderbauer May 19, 2023 17:19
goderbauer
goderbauer approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented May 19, 2023

test-exempt: code refactor with no semantic change

@pq pq mentioned this pull request May 19, 2023
Open
@pq pq added the autosubmit Merge PR when tree becomes green via auto submit App label May 19, 2023
@auto-submit auto-submit bot merged commit d0c0439 into flutter:master May 19, 2023
139 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
38bdef1 
…er#127211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
4c0260e 
…er#127211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
468d72b 
…er#127211)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
59c59fa 
…er#127211)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 22, 2023
@engine-flutter-autoroll
Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) (#4051)
3721658 
flutter/flutter@077d644...ab57304

2023-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (flutter/flutter#127241)
2023-05-20 andrewrkolos@gmail.com Reland "[tool] Move Java functions to their own file" (flutter/flutter#126577)
2023-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (flutter/flutter#127240)
2023-05-19 82336674+gilnobrega@users.noreply.github.com Do not animate `TabBarView` if controller is invalid (flutter/flutter#123442)
2023-05-19 54558023+keyonghan@users.noreply.github.com Run Mac intel only targets on both intel and arm (flutter/flutter#127230)
2023-05-19 737941+loic-sharma@users.noreply.github.com [Windows] Ensure window is shown (flutter/flutter#127046)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (flutter/flutter#127233)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (flutter/flutter#127224)
2023-05-19 pq@users.noreply.github.com fixes to anticipate next Dart linter release (flutter/flutter#127211)
2023-05-19 katelovett@google.com Remove deprecated OverscrollIndicatorNotification.disallowGlow (flutter/flutter#127050)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (flutter/flutter#127221)
2023-05-19 christopherfujino@gmail.com [flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (flutter/flutter#127150)
2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/flutter#127218)
2023-05-19 engine-flutter-autoroll@skia.org Roll Packages from b31a128 to 1e214d7 (3 revisions) (flutter/flutter#127217)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (flutter/flutter#127212)
2023-05-19 joshualitt@google.com Revert "Migrate benchmarks to package:web" (flutter/flutter#127207)
2023-05-19 ychris@google.com [tool] delete xcresult bundle file before each xcode retry. (flutter/flutter#127144)
2023-05-19 vashworth@google.com [iOS] Dispose of log readers and port forwarders if launch fails (flutter/flutter#127140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@pq
fixes to anticipate next Dart linter release (flutter#127211)
c58c630 
The upcoming linter release notices null literals as unnecessary argument values and flags more `type_literal_in_constant_pattern` cases. 

See breakages: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8780744067138629361/+/u/analyze_flutter_flutter/stdout
This was referenced May 25, 2023
Merged
Merged
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 077d644bbc5f to ab573048e74d (18 revisions) (flutte…
3f008ef 
…r#4051)

flutter/flutter@077d644...ab57304

2023-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 482c99af9c69 to aac09195688d (1 revision) (flutter/flutter#127241)
2023-05-20 andrewrkolos@gmail.com Reland "[tool] Move Java functions to their own file" (flutter/flutter#126577)
2023-05-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f0c02aee69db to 482c99af9c69 (1 revision) (flutter/flutter#127240)
2023-05-19 82336674+gilnobrega@users.noreply.github.com Do not animate `TabBarView` if controller is invalid (flutter/flutter#123442)
2023-05-19 54558023+keyonghan@users.noreply.github.com Run Mac intel only targets on both intel and arm (flutter/flutter#127230)
2023-05-19 737941+loic-sharma@users.noreply.github.com [Windows] Ensure window is shown (flutter/flutter#127046)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3267fa29491a to f0c02aee69db (4 revisions) (flutter/flutter#127233)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2b14f8a1f21c to 3267fa29491a (4 revisions) (flutter/flutter#127224)
2023-05-19 pq@users.noreply.github.com fixes to anticipate next Dart linter release (flutter/flutter#127211)
2023-05-19 katelovett@google.com Remove deprecated OverscrollIndicatorNotification.disallowGlow (flutter/flutter#127050)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from f471b37a2146 to 2b14f8a1f21c (1 revision) (flutter/flutter#127221)
2023-05-19 christopherfujino@gmail.com [flutter_tools] only try to take a screenshot from flutter drive if the --screenshot flag is passed (flutter/flutter#127150)
2023-05-19 zanderso@users.noreply.github.com Roll goldctl to f808dcff91b221ae313e540c09d79696cd08b8de (flutter/flutter#127218)
2023-05-19 engine-flutter-autoroll@skia.org Roll Packages from b31a128 to 1e214d7 (3 revisions) (flutter/flutter#127217)
2023-05-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from a0ea4d2d9ea5 to f471b37a2146 (1 revision) (flutter/flutter#127212)
2023-05-19 joshualitt@google.com Revert "Migrate benchmarks to package:web" (flutter/flutter#127207)
2023-05-19 ychris@google.com [tool] delete xcresult bundle file before each xcode retry. (flutter/flutter#127144)
2023-05-19 vashworth@google.com [iOS] Dispose of log readers and port forwarders if launch fails (flutter/flutter#127140)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
4f6ef3f 
…er#127211)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
9c7ef70 
…er#127211)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
37a5d41 
…er#127211)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d0c0439b8 fixes to anticipate next Dart linter release (flutter/flutt…
11d7fb1 
…er#127211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pq @Hixie @goderbauer