Log all output of ios-deploy #127222

vashworth · 2023-05-19T18:51:54Z

Log all output of ios-deploy to try and determine if the issue of #121231 is with stream or with ios-deploy.

Note: This will cause some duplicate logs like example below but only in verbose mode

(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
(lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend.
2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/
VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-05-22T18:32:11Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

christopherfujino · 2023-05-22T18:59:32Z

packages/flutter_tools/lib/src/ios/ios_deploy.dart

+
+        // TODO(vashworth): Revert after https://github.com/flutter/flutter/issues/121231 is resolved.
+        if (line.isNotEmpty) {
+          _logger.printTrace(line);


Can you add a test for this in test/general.shard/ios/ios_deploy_test.dart? Looks like we have prior art.

My bad, I thought just logs didn't need a test. Also, not sure what you mean by "prior art", but I added a test.

christopherfujino

LGTM

This reverts commit 7fa45ea.

Reverts #127222

flutter/flutter@f86c529...216605b 2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from aba9dc4640c2 to eebcf36cd38f (3 revisions) (flutter/flutter#127458) 2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76afb431a740 to aba9dc4640c2 (1 revision) (flutter/flutter#127453) 2023-05-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc6df9512aa2 to 76afb431a740 (3 revisions) (flutter/flutter#127445) 2023-05-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 6b107e7a7ee5e054e0bcce60de5181d21e2f00fb to 2713f7303c96cb1e69627957ec16eea0fd7f94a4 (flutter/flutter#127438) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3535e0d301dd to fc6df9512aa2 (1 revision) (flutter/flutter#127440) 2023-05-23 47866232+chunhtai@users.noreply.github.com Migrates android semanitcs integration to integration test (flutter/flutter#127128) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 23b04314d5d2 to 3535e0d301dd (3 revisions) (flutter/flutter#127428) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from ccf50f344d5d to 23b04314d5d2 (2 revisions) (flutter/flutter#127421) 2023-05-23 ian@hixie.ch Give channel descriptions in `flutter channel`, use branch instead of upstream for channel name (flutter/flutter#126936) 2023-05-23 72562119+tgucio@users.noreply.github.com Avoid catching errors in TextPainter tests (flutter/flutter#127307) 2023-05-23 christopherfujino@gmail.com [flutter_tools] delete entitlements files after copying to macos build dir (flutter/flutter#127417) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from a6e37bde65fd to ccf50f344d5d (7 revisions) (flutter/flutter#127416) 2023-05-23 113669907+NikolajHarderNota@users.noreply.github.com modal bottom sheet barrier label (flutter/flutter#126431) 2023-05-23 jmccandless@google.com Fix the breaking of multi-code-unit characters in obscure mode (flutter/flutter#123366) 2023-05-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 168b0bf3f70d to a6e37bde65fd (1 revision) (flutter/flutter#127397) 2023-05-23 vashworth@google.com Revert "Log all output of ios-deploy" (flutter/flutter#127405) 2023-05-23 engine-flutter-autoroll@skia.org Roll Packages from 83959fb to d449a17 (6 revisions) (flutter/flutter#127394) 2023-05-23 vashworth@google.com Log all output of ios-deploy (flutter/flutter#127222) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Log all output of `ios-deploy` to try and determine if the issue of flutter#121231 is with stream or with `ios-deploy`. Note: This will cause some duplicate logs like example below but only in verbose mode ``` (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. (lldb) 2023-05-19 13:48:19.107935-0500 Runner[2521:390363] [VERBOSE-2:FlutterDarwinContextMetalImpeller.mm(35)] Using the Impeller rendering backend. 2023-05-19 13:48:19.156866-0500 Runner[2521:390612] flutter: The Dart VM service is listening on http://127.0.0.1:63508/IsFnhXJykCM=/ VM Service URL on device: http://127.0.0.1:63508/IsFnhXJykCM=/ ```

Reverts flutter#127222

Reland #127222 that was reverted in #127405. Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.

vashworth added 2 commits May 19, 2023 13:43

log every line from ios-deploy

16f7a4f

add todo

39841b9

flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 19, 2023

vashworth added 2 commits May 22, 2023 13:29

fix TODO comment and adjust print statements

5517944

Merge branch 'master' into dart_vm_timeout_debug_v2

86764ad

vashworth marked this pull request as ready for review May 22, 2023 18:31

vashworth requested a review from christopherfujino May 22, 2023 18:31

christopherfujino reviewed May 22, 2023

View reviewed changes

add test

3218eae

christopherfujino approved these changes May 22, 2023

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2023

auto-submit bot merged commit 7fa45ea into flutter:master May 23, 2023
124 checks passed

vashworth added a commit to vashworth/flutter that referenced this pull request May 23, 2023

Revert "Log all output of ios-deploy (flutter#127222)"

60015f2

This reverts commit 7fa45ea.

vashworth mentioned this pull request May 23, 2023

Revert "Log all output of ios-deploy" #127405

Merged

vashworth added a commit that referenced this pull request May 23, 2023

Revert "Log all output of ios-deploy (#127222)"

66f86b5

This reverts commit 7fa45ea.

auto-submit bot pushed a commit that referenced this pull request May 23, 2023

Revert "Log all output of ios-deploy" (#127405)

d452ce9

Reverts #127222

engine-flutter-autoroll mentioned this pull request May 24, 2023

Roll Flutter from f86c529b2cd2 to 216605b60f67 (18 revisions) flutter/packages#4071

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2023

7fa45ea48 Log all output of ios-deploy (flutter/flutter#127222)

03358c6

vashworth mentioned this pull request May 24, 2023

Log all lines from ios-deploy #127502

Merged

8 tasks

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023

Revert "Log all output of ios-deploy" (flutter#127405)

6b0f0c4

Reverts flutter#127222

auto-submit bot pushed a commit that referenced this pull request May 24, 2023

Log all lines from ios-deploy (#127502)

a19b343

Reland #127222 that was reverted in #127405. Fixed `Mac_ios microbenchmarks_ios` test failure by not echoing logs twice.

This was referenced May 25, 2023

Support minifcation for apps that depend on AGP 8 and integration_test #127628

Merged

i127682 android api 33 test support #127689

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

7fa45ea48 Log all output of ios-deploy (flutter/flutter#127222)

9872d4a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7fa45ea48 Log all output of ios-deploy (flutter/flutter#127222)

9fcf257

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7fa45ea48 Log all output of ios-deploy (flutter/flutter#127222)

20656b3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

7fa45ea48 Log all output of ios-deploy (flutter/flutter#127222)

f0e948b

vashworth deleted the dart_vm_timeout_debug_v2 branch September 27, 2023 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log all output of ios-deploy #127222

Log all output of ios-deploy #127222

vashworth commented May 19, 2023 •

edited

flutter-dashboard bot commented May 22, 2023

christopherfujino May 22, 2023

vashworth May 22, 2023

christopherfujino left a comment

Log all output of ios-deploy #127222

Log all output of ios-deploy #127222

Conversation

vashworth commented May 19, 2023 • edited

Pre-launch Checklist

flutter-dashboard bot commented May 22, 2023

christopherfujino May 22, 2023

Choose a reason for hiding this comment

vashworth May 22, 2023

Choose a reason for hiding this comment

christopherfujino left a comment

Choose a reason for hiding this comment

vashworth commented May 19, 2023 •

edited