Tap on button behind snack bar defined by margin #127959

lsaudon · 2023-05-31T15:09:22Z

If the margin is used, set the HitTestBehavior to deferToChild.

List which issues are fixed by this PR. You must list at least one issue.
#78537
#114810

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

kitsuniru · 2023-06-22T10:56:29Z

why not also let the developer choose the hitTestBehavior parameter himself?

#114810 - like here

lsaudon · 2023-06-22T11:44:48Z

why not also let the developer choose the hitTestBehavior parameter himself?

#114810 - like here

Because I don't want to have to know that I have to put in a hitTestBehavior when I change the margin.
I don't find that logical.
Leaving the choice means that I fix the bug only for those who know about it.

I can do this

behavior: widget.hitTestBehavior ?? widget.margin != null
            ? HitTestBehavior.deferToChild
            : HitTestBehavior.opaque,

bleroux · 2023-06-23T07:31:11Z

I can do this

behavior: widget.hitTestBehavior ?? widget.margin != null
            ? HitTestBehavior.deferToChild
            : HitTestBehavior.opaque,

I too think it would be great to update the PR this way.

bleroux

A few minor comments on the tests code.

packages/flutter/test/material/snack_bar_test.dart

lsaudon · 2023-06-23T08:28:05Z

I can do this

behavior: widget.hitTestBehavior ?? widget.margin != null
            ? HitTestBehavior.deferToChild
            : HitTestBehavior.opaque,

I too think it would be great to update the PR this way.

I added it.

bleroux

LGTM!
Thanks @lsaudon and @hot-moms

cc @justinmc for a review (because you reviewed #114810)

justinmc

LGTM 👍 Good call adding the hitTestBehavior parameter as well.

packages/flutter/lib/src/material/snack_bar.dart

bleroux

@lsaudon Thanks for you patience, just another step left to polish the comments.

packages/flutter/lib/src/material/snack_bar.dart

…lutter#127959)

If the margin is used, set the `HitTestBehavior` to `deferToChild`. *List which issues are fixed by this PR. You must list at least one issue.* flutter#78537 flutter#114810 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

…rThemeData.insetPadding is not null (#148568) The PR changes the default value of hitTestBehavior in snack bars to `HitTestBehavior.deferToChild` when snackBarTheme.insetPadding is not null, so that widgets behind snack bars affected by the value set to insetPadding, remain interactive even while a snack bar is visible. This PR can be considered as an extension to what have been done in PR #127959 which fixes the same problem but for individual snack bars with margin not being null. This PR works on the theme level. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* #148566

…rThemeData.insetPadding is not null (flutter#148568) The PR changes the default value of hitTestBehavior in snack bars to `HitTestBehavior.deferToChild` when snackBarTheme.insetPadding is not null, so that widgets behind snack bars affected by the value set to insetPadding, remain interactive even while a snack bar is visible. This PR can be considered as an extension to what have been done in PR flutter#127959 which fixes the same problem but for individual snack bars with margin not being null. This PR works on the theme level. *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* flutter#148566

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2023

github-actions bot removed the framework flutter/packages/flutter repository. See also f: labels. label May 31, 2023

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 23, 2023

bleroux reviewed Jun 23, 2023

View reviewed changes

packages/flutter/test/material/snack_bar_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/snack_bar_test.dart Show resolved Hide resolved

packages/flutter/test/material/snack_bar_test.dart Show resolved Hide resolved

bleroux approved these changes Jun 23, 2023

View reviewed changes

bleroux requested a review from justinmc June 23, 2023 09:48

justinmc approved these changes Jun 26, 2023

View reviewed changes

packages/flutter/lib/src/material/snack_bar.dart Show resolved Hide resolved

bleroux reviewed Jul 11, 2023

View reviewed changes

packages/flutter/lib/src/material/snack_bar.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/snack_bar.dart Outdated Show resolved Hide resolved

lsaudon added 2 commits July 12, 2023 23:15

Tap on button behind snack bar defined by margin

5ed2df9

Add documentation for margin and hitTestBehavior

5c562d1

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023

auto-submit bot merged commit c3cd016 into flutter:master Jul 14, 2023
73 checks passed

This was referenced Jul 14, 2023

Can't click on the items under the snackbar with margin #78537

Closed

[Feature request] Option to ignore pointer events for SnackBar #92787

Open

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

7f7a57e

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

b22f47b

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

9af75f6

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b91aedb17579 (43 revisions) flutter/packages#4467

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

279d6e4

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 79119dfc66c6 (44 revisions) flutter/packages#4468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

f322632

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to a903f1defb15 (45 revisions) flutter/packages#4470

Closed

engine-flutter-autoroll mentioned this pull request Jul 16, 2023

Roll Flutter from c40173f114fa to 4f437d4765de (67 revisions) flutter/packages#4488

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

b3a69fe

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 3a1190a5a85c (72 revisions) flutter/packages#4492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

1630d9d

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 526522d9e5c7 (74 revisions) flutter/packages#4493

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

bf16cee

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7a42ed7ef6ed (76 revisions) flutter/packages#4495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

9e70e8d

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 6f09064e785b (77 revisions) flutter/packages#4496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

ab3bba0

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 083d18e83f8f (78 revisions) flutter/packages#4497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

dd7e346

…lutter#127959)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7937b1d51f7b (80 revisions) flutter/packages#4498

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

47a0920

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

e9b80b4

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

c0264d9

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

4fa69fc

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

626ef2f

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

7108418

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

b58b621

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

f2cd6d0

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

ede2d61

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

5ca2e47

…lutter#127959)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

c3cd01661 Tap on button behind snack bar defined by margin (flutter/f…

ada3bde

…lutter#127959)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Open

lsaudon deleted the snackbar-margin-tap branch September 15, 2023 07:47

hany-achraf mentioned this pull request May 17, 2024

Change snack bar default hitTestBehavior to deferToChild when SnackBarThemeData.insetPadding is not null #148568

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tap on button behind snack bar defined by margin #127959

Tap on button behind snack bar defined by margin #127959

lsaudon commented May 31, 2023

kitsuniru commented Jun 22, 2023

lsaudon commented Jun 22, 2023

bleroux commented Jun 23, 2023 •

edited

Loading

bleroux left a comment

lsaudon commented Jun 23, 2023

bleroux left a comment

justinmc left a comment

bleroux left a comment

Tap on button behind snack bar defined by margin #127959

Tap on button behind snack bar defined by margin #127959

Conversation

lsaudon commented May 31, 2023

Pre-launch Checklist

kitsuniru commented Jun 22, 2023

lsaudon commented Jun 22, 2023

bleroux commented Jun 23, 2023 • edited Loading

bleroux left a comment

Choose a reason for hiding this comment

lsaudon commented Jun 23, 2023

bleroux left a comment

Choose a reason for hiding this comment

justinmc left a comment

Choose a reason for hiding this comment

bleroux left a comment

Choose a reason for hiding this comment

bleroux commented Jun 23, 2023 •

edited

Loading