Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifies semantics long press and semantics on tap documentation #128599

Merged
merged 1 commit into from Jun 9, 2023
Merged

Clarifies semantics long press and semantics on tap documentation #128599

merged 1 commit into from Jun 9, 2023

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Jun 9, 2023

fixes #35112

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. labels Jun 9, 2023
@chunhtai chunhtai requested a review from hangyujin June 9, 2023 17:16
hangyujin
hangyujin approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@hangyujin hangyujin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit auto-submit bot merged commit cc6f86e into flutter:master Jun 9, 2023
72 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
05d5321 
…tation (flutter/flutter#128599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
c5f9c12 
…tation (flutter/flutter#128599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
fdb4a64 
…tation (flutter/flutter#128599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
6ba7650 
…tation (flutter/flutter#128599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
72e7565 
…tation (flutter/flutter#128599)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 11, 2023
@engine-flutter-autoroll
Roll Flutter from da127f15ad54 to 3df163ff081e (25 revisions) (#4183)
c9865e8 
flutter/flutter@da127f1...3df163f

2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73a7af805472 to 1cca9cc6dbd1 (1 revision) (flutter/flutter#128658)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c6770083e5c to 73a7af805472 (2 revisions) (flutter/flutter#128654)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d615bbcfccf to 7c6770083e5c (2 revisions) (flutter/flutter#128653)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from b19b93de5b0a to 6d615bbcfccf (1 revision) (flutter/flutter#128650)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3d76ba6d6d5f to b19b93de5b0a (2 revisions) (flutter/flutter#128649)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 962d78e0ae9c to 3d76ba6d6d5f (1 revision) (flutter/flutter#128645)
2023-06-10 31859944+LongCatIsLooong@users.noreply.github.com migrate `Tooltip` to use  `OverlayPortal` (flutter/flutter#127728)
2023-06-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b037db26037f to 962d78e0ae9c (10 revisions) (flutter/flutter#128643)
2023-06-10 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.2 to 3.5.3 (flutter/flutter#128625)
2023-06-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3e90345cdca7 to b037db26037f (1 revision) (flutter/flutter#128627)
2023-06-10 devZhulanov.A.A@gmail.com Remove unnecessary parentheses (flutter/flutter#128620)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 488876ed26c6 to 3e90345cdca7 (3 revisions) (flutter/flutter#128617)
2023-06-09 andrewrkolos@gmail.com rename generated asset manifest file back to `AssetManifest.bin` (from `AssetManifest.smcbin`) (flutter/flutter#128529)
2023-06-09 jhy03261997@gmail.com Add Selected semantics to IconButton (flutter/flutter#128547)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 071e1fb21c7a to 488876ed26c6 (5 revisions) (flutter/flutter#128612)
2023-06-09 47866232+chunhtai@users.noreply.github.com Clarifies semantics long press and semantics on tap documentation (flutter/flutter#128599)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc6e047570f6 to 071e1fb21c7a (1 revision) (flutter/flutter#128602)
2023-06-09 hans.muller@gmail.com Revert "Update `chip.dart` to use set of `MaterialState`" (flutter/flutter#128607)
2023-06-09 devZhulanov.A.A@gmail.com Add tooltips for `SegmentedButton` (flutter/flutter#128501)
2023-06-09 jason-simmons@users.noreply.github.com Ignore app.stop events received before the app.detach response in attach integration tests (flutter/flutter#128593)
2023-06-09 dleyba042@gmail.com ExpansionPanel isExpanded callback parameter (Ticket 74114) (flutter/flutter#128082)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93afba901b3b to bc6e047570f6 (3 revisions) (flutter/flutter#128594)
2023-06-09 hans.muller@gmail.com Updated flutter_localizations tests for Material3; (flutter/flutter#128521)
2023-06-09 jhy03261997@gmail.com Paint SelectableFragments before text (flutter/flutter#128375)
2023-06-09 engine-flutter-autoroll@skia.org Roll Packages from e13b8c4 to afe2f05 (7 revisions) (flutter/flutter#128582)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Jun 16, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
c0d6d63 
…tation (flutter/flutter#128599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
1234cc9 
…tation (flutter/flutter#128599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
dadf5ff 
…tation (flutter/flutter#128599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cc6f86e6e Clarifies semantics long press and semantics on tap documen…
3a9e644 
…tation (flutter/flutter#128599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hangyujin hangyujin hangyujin approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the documentation of Semantics' onLongPress
2 participants
@chunhtai @hangyujin