Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashes on range errors when selecting device #129290

Merged
merged 7 commits into from Jun 22, 2023
Merged

Prevent crashes on range errors when selecting device #129290

merged 7 commits into from Jun 22, 2023

Commits on Jun 21, 2023

  1. Prevent user from typing 0 during device selection

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b6b6094 View commit details
    Browse the repository at this point in the history

  2. Add test + correct selection logic for TargetDevices

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    472c8fe View commit details
    Browse the repository at this point in the history

  3. Revert unnecessary logic for TargetDevices 

    `globals.terminal.promptForCharInput` method already checks that the input is valid
    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    5326296 View commit details
    Browse the repository at this point in the history

  4. Removing accompanying test for TargetDevices

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    931565d View commit details
    Browse the repository at this point in the history

  5. Clean up

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    530f8a9 View commit details
    Browse the repository at this point in the history

  6. Adding test to validate having invalid user inputs for device

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    dc1315a View commit details
    Browse the repository at this point in the history

  7. Add device id that exceeds top bounds

    @eliasyishak
    eliasyishak committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    2091fcd View commit details
    Browse the repository at this point in the history