Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run misc test shard when examples/api/** change #129433

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Run misc test shard when examples/api/** change #129433

merged 1 commit into from
Jun 23, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 23, 2023

Fixes #129390

Found in #129381, changing sample code in examples/api did not trigger the misc test shard that executes the tests for examples/api.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos team-infra Owned by Infrastructure team labels Jun 23, 2023
@Piinks Piinks requested a review from godofredoc June 23, 2023 15:48
@github-actions github-actions bot removed a: tests "flutter test", flutter_test, or one of our tests d: examples Sample code and demos d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jun 23, 2023
@Piinks Piinks mentioned this pull request Jun 23, 2023
Open
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 23, 2023
This was referenced Jun 23, 2023
Closed
Merged
@auto-submit auto-submit bot merged commit 309e501 into flutter:master Jun 23, 2023
135 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
51b529c 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
8b010f2 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
48e77fc 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
b0d1dcc 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
7dd8661 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
8074b3f 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
87b9064 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
5b38a1b 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
e81cff3 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
5492525 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
9a8a3cc 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
c345780 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
dc685ff 
…utter#129433)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
ad29a43 
…utter#129433)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
Roll Flutter from 042c0366c9a9 to 96a2c0535810 (60 revisions) (#4313)
4e71ead 
Roll Flutter from 042c0366c9a9 to 96a2c0535810 (60 revisions)

flutter/flutter@042c036...96a2c05

2023-06-26 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/flutter#129453)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 63582320d20e to 4032a9bc964e (2 revisions) (flutter/flutter#129569)
2023-06-26 hans.muller@gmail.com Updated TextMagnifierExampleApp to M3 (flutter/flutter#129381)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from debee7cece49 to 63582320d20e (3 revisions) (flutter/flutter#129563)
2023-06-26 tessertaha@gmail.com Fix `AnimatedList` & `AnimatedGrid` doesn't apply `MediaQuery` padding (flutter/flutter#129556)
2023-06-26 godofredoc@google.com Process only specific labels. (flutter/flutter#129475)
2023-06-26 engine-flutter-autoroll@skia.org Roll Packages from d041934 to 6b70804 (7 revisions) (flutter/flutter#129559)
2023-06-26 ian@hixie.ch Make bug templates more consistent (flutter/flutter#129460)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from be46101e952d to debee7cece49 (1 revision) (flutter/flutter#129544)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 88ff46e1efc1 to be46101e952d (2 revisions) (flutter/flutter#129540)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 317673b3278a to 88ff46e1efc1 (1 revision) (flutter/flutter#129534)
2023-06-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 593e1d9a9cf5 to 317673b3278a (3 revisions) (flutter/flutter#129531)
2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5178e8ab7764 to 593e1d9a9cf5 (1 revision) (flutter/flutter#129514)
2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 100f6fc854b4 to 5178e8ab7764 (1 revision) (flutter/flutter#129508)
2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9f446e25f0c to 100f6fc854b4 (1 revision) (flutter/flutter#129498)
2023-06-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b1b98305768 to a9f446e25f0c (1 revision) (flutter/flutter#129495)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72c902ce3b81 to 5b1b98305768 (2 revisions) (flutter/flutter#129493)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2976add9414 to 72c902ce3b81 (1 revision) (flutter/flutter#129489)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 76a5e971dc09 to f2976add9414 (1 revision) (flutter/flutter#129487)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 79fd6beea087 to 76a5e971dc09 (1 revision) (flutter/flutter#129483)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 30ac9107f2f9 to 79fd6beea087 (1 revision) (flutter/flutter#129479)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from ee65380bf3fd to 30ac9107f2f9 (1 revision) (flutter/flutter#129476)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 240a86f40781 to ee65380bf3fd (2 revisions) (flutter/flutter#129474)
2023-06-24 godofredoc@google.com Fix issues with no response bot. (flutter/flutter#129470)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e6dcf959ea0 to 240a86f40781 (1 revision) (flutter/flutter#129473)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from 550bfedc8760 to 5e6dcf959ea0 (1 revision) (flutter/flutter#129468)
2023-06-24 engine-flutter-autoroll@skia.org Roll Flutter Engine from c1abd1f17ab1 to 550bfedc8760 (3 revisions) (flutter/flutter#129466)
2023-06-24 bdero@google.com [devicelab] Add platform view scroll benchmarks for Impeller on Android (flutter/flutter#129455)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from eca910dd5e3f to c1abd1f17ab1 (3 revisions) (flutter/flutter#129456)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from f8a39cb4dc56 to eca910dd5e3f (3 revisions) (flutter/flutter#129451)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 74ef61859bdc to f8a39cb4dc56 (2 revisions) (flutter/flutter#129445)
2023-06-23 737941+loic-sharma@users.noreply.github.com Add CallbackShortcuts widget of the week video (flutter/flutter#129296)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 060cd9c17df3 to 74ef61859bdc (3 revisions) (flutter/flutter#129444)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd30a48ef889 to 060cd9c17df3 (3 revisions) (flutter/flutter#129440)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from 27f3498286ff to cd30a48ef889 (4 revisions) (flutter/flutter#129437)
2023-06-23 godofredoc@google.com Add a devicelab test to recipes cq. (flutter/flutter#129411)
2023-06-23 paurakh011@gmail.com fix: Inconsistency of SelectionArea when scrolling (flutter/flutter#128765)
2023-06-23 katelovett@google.com Run misc test shard when examples/api/** change (flutter/flutter#129433)
2023-06-23 49699333+dependabot[bot]@users.noreply.github.com Bump ubuntu from `b795f8e` to `db8bf6f` in /dev/ci/docker_linux (flutter/flutter#128740)
2023-06-23 godofredoc@google.com Add r: timeout label to bugs/pr closed by no response bot. (flutter/flutter#129408)
2023-06-23 godofredoc@google.com Remove .github/move.yml. (flutter/flutter#129409)
2023-06-23 engine-flutter-autoroll@skia.org Roll Packages from 95bc1c6 to d041934 (6 revisions) (flutter/flutter#129429)
2023-06-23 engine-flutter-autoroll@skia.org Roll Flutter Engine from aca26b2afc27 to 27f3498286ff (16 revisions) (flutter/flutter#129421)
2023-06-23 godofredoc@google.com Add comments to .ci.yaml that were removed from recipes. (flutter/flutter#129321)
2023-06-23 godofredoc@google.com Update no response to use core action. (flutter/flutter#129405)
2023-06-23 xilaizhang@google.com Revert "[web] Migrate framework to fully use package:web" (flutter/flutter#129400)
...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
9d1c28f 
…utter#129433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
54b4017 
…utter#129433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
b8bc005 
…utter#129433)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
309e50173 Run misc test shard when examples/api/** change (flutter/fl…
443efdc 
…utter#129433)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change in API docs samples did not trigger tests in presubmit
2 participants
@Piinks @godofredoc