Unifies text field focus management in desktops #129652

chunhtai · 2023-06-27T18:55:51Z

The web engine requires a way to unfocus textfield, It comes to nature to me that we should leverage didGain/didLose a11y focus action. I also unifies the action handler of all desktop platforms

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai · 2023-07-07T22:26:18Z

IMG_0001.MOV

Tested with ios web, looks normal

yjbanov · 2023-07-11T21:33:27Z

packages/flutter/lib/src/material/text_field.dart

@@ -1313,6 +1314,11 @@ class _TextFieldState extends State<TextField> with RestorationMixin implements
            _effectiveFocusNode.requestFocus();
          }
        };
+        handleDidLoseAccessibilityFocus = () {
+          if (_effectiveFocusNode.hasFocus) {


This check is not necessary. FocusNode already checks for hasFocus and a couple of other things.

yjbanov · 2023-07-11T21:35:10Z

packages/flutter/lib/src/material/text_field.dart

+          }
+        };
+        handleDidLoseAccessibilityFocus = () {
+          if (_effectiveFocusNode.hasFocus) {


yjbanov · 2023-07-11T21:35:18Z

packages/flutter/lib/src/material/text_field.dart

@@ -1344,6 +1361,11 @@ class _TextFieldState extends State<TextField> with RestorationMixin implements
            _effectiveFocusNode.requestFocus();
          }
        };
+        handleDidLoseAccessibilityFocus = () {
+          if (_effectiveFocusNode.hasFocus) {


auto-submit · 2023-07-12T21:57:48Z

auto label is removed for flutter/flutter, pr: 129652, due to - The status or check suite Linux firebase_oriol33_abstract_method_smoke_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

CaseyHillers · 2023-07-13T17:37:02Z

Google testing is stuck as pending due to the test results being cleaned up. The latest results passed the smoke test, so this is safe to land.

There's an internal breakage where we're unable to override the GitHub status (b/291100012)

chunhtai · 2023-07-13T17:41:47Z

Manually landed the pr as google test can't be overridden

…ion (#43279) fixes flutter/flutter#128709 requires flutter/flutter#129652 The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

related flutter#128709 engine PR: flutter/engine#43279 The web engine requires a way to unfocus textfield, It comes to nature to me that we should leverage didGain/didLose a11y focus action. I also unifies the action handler of all desktop platforms ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [ ] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…utter#129652)

…ion (flutter#43279) fixes flutter/flutter#128709 requires flutter/flutter#129652 The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…utter#129652)

…ion (flutter#43279) fixes flutter/flutter#128709 requires flutter/flutter#129652 The issue is that when textfield focus in framework and web engine a11y are out of sync, the framework keep sending update with textfield focus = true and causes web engine to keep refocusing the textfield. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

chunhtai mentioned this pull request Jun 27, 2023

[web] TextField a11y focus should call didGain/didLose a11y focus action flutter/engine#43279

Merged

8 tasks

chunhtai requested review from yjbanov and mdebbar June 27, 2023 19:02

chunhtai added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Jun 27, 2023

goderbauer added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 5, 2023

chunhtai force-pushed the issues/128709 branch from 3ebc21e to a07b338 Compare July 7, 2023 16:04

github-actions bot added a: text input Entering text in a text field or keyboard related problems and removed a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Jul 7, 2023

yjbanov approved these changes Jul 11, 2023

View reviewed changes

chunhtai force-pushed the issues/128709 branch from a07b338 to 8553e83 Compare July 12, 2023 17:24

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023

chunhtai added 2 commits July 12, 2023 13:55

Unifies text field focus management in desktops

ac4cbb0

fix test and comments

825bb08

chunhtai force-pushed the issues/128709 branch from 8553e83 to 825bb08 Compare July 12, 2023 20:55

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2023

chunhtai merged commit 2e8af2c into flutter:master Jul 13, 2023
72 of 73 checks passed

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

daa5313

…utter#129652)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

6244521

…utter#129652)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

da1498f

…utter#129652)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to d5e7f407e120 (47 revisions) flutter/packages#4471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

2d63ce7

…utter#129652)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 934d20864d07 (48 revisions) flutter/packages#4474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

0e41c62

…utter#129652)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 56b5cc908304 (49 revisions) flutter/packages#4475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

d9d314b

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

cc96df6

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

aae8233

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

072a83a

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

f450a07

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

c19e9d9

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

cb0d281

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

b77c04b

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

c2e2c37

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

3a29104

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

68bc461

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

e5602d6

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

9000578

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

c5e6868

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

1633d9f

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

2dfbe42

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

0391918

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

9fc005f

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

486b824

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

dc15d25

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

089fd94

…utter#129652)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

2e8af2c35 Unifies text field focus management in desktops (flutter/fl…

131872e

…utter#129652)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unifies text field focus management in desktops #129652

Unifies text field focus management in desktops #129652

chunhtai commented Jun 27, 2023 •

edited

Loading

chunhtai commented Jul 7, 2023

yjbanov Jul 11, 2023

yjbanov Jul 11, 2023

yjbanov Jul 11, 2023

auto-submit bot commented Jul 12, 2023

CaseyHillers commented Jul 13, 2023

chunhtai commented Jul 13, 2023

Unifies text field focus management in desktops #129652

Unifies text field focus management in desktops #129652

Conversation

chunhtai commented Jun 27, 2023 • edited Loading

Pre-launch Checklist

chunhtai commented Jul 7, 2023

yjbanov Jul 11, 2023

Choose a reason for hiding this comment

yjbanov Jul 11, 2023

Choose a reason for hiding this comment

yjbanov Jul 11, 2023

Choose a reason for hiding this comment

auto-submit bot commented Jul 12, 2023

CaseyHillers commented Jul 13, 2023

chunhtai commented Jul 13, 2023

chunhtai commented Jun 27, 2023 •

edited

Loading