Change the default for`ThemeData.useMaterial3` to true #129724

HansMuller · 2023-06-28T16:50:31Z

Changes the default for ThemeData.useMaterial3 to true.

flutter-dashboard · 2023-06-28T16:50:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

QuncCccccc

LGTM!

…tter/flutter#129724)

chrisbobbe · 2023-07-17T23:09:06Z

I've opened #130761 for updating the doc to reflect this change.

…tter/flutter#129724)

Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets. The test started failing after #129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see #130732 (comment)). Fixes #130732

Changes the default for `ThemeData.useMaterial3` to true. See flutter#127064

…r#131301) Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets. The test started failing after flutter#129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see flutter#130732 (comment)). Fixes flutter#130732

HansMuller mentioned this pull request Jun 28, 2023

☂️ Make useMaterial3: true by default #127064

Closed

25 tasks

HansMuller force-pushed the test_m3_default_update branch from 3d74d44 to 8ef4eb6 Compare June 30, 2023 16:48

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jun 30, 2023

HansMuller force-pushed the test_m3_default_update branch from d6c1a28 to 8db954e Compare July 10, 2023 15:48

(WIP) Verify that making useMaterial3:true is safe

9f6981d

HansMuller force-pushed the test_m3_default_update branch from 8db954e to 9f6981d Compare July 11, 2023 18:26

Merge branch 'master' into test_m3_default_update

abc5b8a

HansMuller changed the title ~~(WIP) Verify that making useMaterial3:true is safe~~ Change the default forThemeData.useMaterial3 to true Jul 12, 2023

HansMuller requested a review from QuncCccccc July 12, 2023 16:23

QuncCccccc approved these changes Jul 12, 2023

View reviewed changes

HansMuller merged commit 157660a into flutter:master Jul 13, 2023
73 checks passed

HansMuller deleted the test_m3_default_update branch July 13, 2023 20:06

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

637e856

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

a5e1a60

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

9ce4891

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b91aedb17579 (43 revisions) flutter/packages#4467

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

96c98c0

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 79119dfc66c6 (44 revisions) flutter/packages#4468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

e7ae7ea

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to a903f1defb15 (45 revisions) flutter/packages#4470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

e1dccfb

…tter/flutter#129724)

zanderso mentioned this pull request Jul 14, 2023

Benchmark regressions on Material 3 change #130595

Open

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to d5e7f407e120 (47 revisions) flutter/packages#4471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

884fd87

…tter/flutter#129724)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 934d20864d07 (48 revisions) flutter/packages#4474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

c0ed1da

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

0132835

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

64d8b81

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

c679fe7

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

edddde2

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

c294418

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

dc01303

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

bf5140d

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

7ccccb0

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

b2bd79e

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

094fa37

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

e24c937

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

bcc1602

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

ac1c173

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

ccfdd93

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

86f4aae

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

56f4d15

…tter/flutter#129724)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

157660afc Change the default forThemeData.useMaterial3 to true (flu…

cce669b

…tter/flutter#129724)

gnprice mentioned this pull request Jul 19, 2023

Migrate to Material 3 zulip/zulip-flutter#225

Closed

7 tasks

This was referenced Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Open

Updated integration_tests/platform_interaction test_step.dart #131301

Merged

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

Change the default forThemeData.useMaterial3 to true (flutter#129724)

4f4c2db

Changes the default for `ThemeData.useMaterial3` to true. See flutter#127064

LongCatIsLooong mentioned this pull request Aug 4, 2023

[latest master][Impeller] widgets disappear too early during perspective animation #130613

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the default for`ThemeData.useMaterial3` to true #129724

Change the default for`ThemeData.useMaterial3` to true #129724

HansMuller commented Jun 28, 2023 •

edited

flutter-dashboard bot commented Jun 28, 2023

QuncCccccc left a comment

chrisbobbe commented Jul 17, 2023

Change the default forThemeData.useMaterial3 to true #129724

Change the default forThemeData.useMaterial3 to true #129724

Conversation

HansMuller commented Jun 28, 2023 • edited

flutter-dashboard bot commented Jun 28, 2023

QuncCccccc left a comment

Choose a reason for hiding this comment

chrisbobbe commented Jul 17, 2023

Change the default for`ThemeData.useMaterial3` to true #129724

Change the default for`ThemeData.useMaterial3` to true #129724

HansMuller commented Jun 28, 2023 •

edited