-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CardTheme
, DrawerTheme
, NavigationBar
, and NavigationRailTheme
tests for M2/M3
#130047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CardTheme
and DrawerTheme
tests for M2/M3 CardTheme
, DrawerTheme
, NavigationBar
, and NavigationRailTheme
tests for M2/M3
Currently there are some test failures, e.g.
|
Thanks for letting me know! I fixed the error yesterday but seems one test can pass locally but not on Github again(error link). Taking a look. |
5d1b346
to
4d9cc18
Compare
4e27d5e
to
cbd727f
Compare
TahaTesser
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TahaTesser
reviewed
Jul 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 14, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 15, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 15, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 15, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 16, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 16, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 17, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 18, 2023
…vigationRailTheme` tests for M2/M3 (flutter/flutter#130047)
LouiseHsu
pushed a commit
to LouiseHsu/flutter
that referenced
this pull request
Jul 31, 2023
…ilTheme` tests for M2/M3 (flutter#130047) Updated unit tests for `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` to have M2 and M3 versions. More info in flutter#127064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated unit tests for
CardTheme
,DrawerTheme
,NavigationBar
, andNavigationRailTheme
to have M2 and M3 versions.More info in #127064
Pre-launch Checklist
///
).