Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CardTheme, DrawerTheme, NavigationBar, and NavigationRailTheme tests for M2/M3 #130047

Merged
merged 10 commits into from
Jul 13, 2023

Conversation

QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Jul 6, 2023

Updated unit tests for CardTheme, DrawerTheme, NavigationBar, and NavigationRailTheme to have M2 and M3 versions.

More info in #127064

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 6, 2023
@QuncCccccc QuncCccccc changed the title Update CardTheme and DrawerTheme tests for M2/M3 Update CardTheme, DrawerTheme, NavigationBar, and NavigationRailTheme tests for M2/M3 Jul 6, 2023
@HansMuller
Copy link
Contributor

Currently there are some test failures, e.g.

 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following TestFailure was thrown running a test:
 Expected: MaterialColor:<MaterialColor(primary value: Color(0xff2196f3))>
   Actual: Color:<Color(0xff6750a4)>
 When the exception was thrown, this was the stack:
 #4      main.<anonymous closure> (file:///b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart:154:5)
 <asynchronous suspension>
 <asynchronous suspension>
 (elided one frame from package:stack_trace)
 This was caught by the test expectation on the following line:
   file:///b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart line 154
 The test description was:
   Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in
   end drawer
 ════════════════════════════════════════════════════════════════════════════════════════════════════
 06:46 +7906 ~23 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart: Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in end drawer [E]
   Test failed. See exception logs above.
   The test description was: Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in end drawer
   

@QuncCccccc
Copy link
Contributor Author

QuncCccccc commented Jul 7, 2023

Currently there are some test failures, e.g.

 ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
 The following TestFailure was thrown running a test:
 Expected: MaterialColor:<MaterialColor(primary value: Color(0xff2196f3))>
   Actual: Color:<Color(0xff6750a4)>
 When the exception was thrown, this was the stack:
 #4      main.<anonymous closure> (file:///b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart:154:5)
 <asynchronous suspension>
 <asynchronous suspension>
 (elided one frame from package:stack_trace)
 This was caught by the test expectation on the following line:
   file:///b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart line 154
 The test description was:
   Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in
   end drawer
 ════════════════════════════════════════════════════════════════════════════════════════════════════
 06:46 +7906 ~23 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/drawer_theme_test.dart: Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in end drawer [E]
   Test failed. See exception logs above.
   The test description was: Material3 - Default values are used when no Drawer or DrawerThemeData properties are specified in end drawer
   

Thanks for letting me know! I fixed the error yesterday but seems one test can pass locally but not on Github again(error link). Taking a look.

@QuncCccccc QuncCccccc force-pushed the update_card_theme_tests branch 2 times, most recently from 5d1b346 to 4d9cc18 Compare July 12, 2023 01:53
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot merged commit 7fc4990 into master Jul 13, 2023
73 checks passed
@auto-submit auto-submit bot deleted the update_card_theme_tests branch July 13, 2023 22:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
…ilTheme` tests for M2/M3 (flutter#130047)

Updated unit tests for `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` to have M2 and M3 versions.

More info in flutter#127064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants