-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print pretty error when xcodebuild fails due to missing simulator #130286
Print pretty error when xcodebuild fails due to missing simulator #130286
Conversation
} | ||
|
||
String? _parseMissingPlatform(String message) { | ||
final RegExp pattern = RegExp(r'error:(.*?) is not installed\. To use with Xcode, first download and install the platform'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems a bit fragile (e.g. apple updates this string). Is there any error code you can use instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately no, there's nothing identifiable about it other than the message
Here's examples of the output/xcresult:
https://github.com/flutter/flutter/pull/130286/files#diff-d3f6153fa6dc8bb8da44d3b36e987346a3f92af86eed53babfcd91088f7e0d07R256-R270
https://github.com/flutter/flutter/pull/130286/files#diff-6dbb589bcbf47676289bc9a0c2103a8eef5debc5ee3090f6ab750c8af13a57b6R433
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i must have imagined i reviewed this but didn't. lgtm
…utter#130286) Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. If you try to run flutter and the simulator is missing, you'll get an error like ``` xcodebuild: error: Unable to find a destination matching the provided destination specifier: { id:B1234A5C-67B8-901D-B2CB-FE34F56BDE78 } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 17.0 is not installed. To use with Xcode, first download and install the platform } ``` Print a pretty error to make it easier for developers to know what to do. Part 2 of flutter#129558.
…ator #130286" (#130506) Reland #130286 with fix. It failed the first time because of a discrepancy between the master branch and my branch (see #130504 (comment) for more info).
…ator flutter#130286" (flutter#130506) Reland flutter#130286 with fix. It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
…ator flutter#130286" (flutter#130506) Reland flutter#130286 with fix. It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).
Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately.
If you try to run flutter and the simulator is missing, you'll get an error like
Print a pretty error to make it easier for developers to know what to do.
Part 2 of #129558.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.