Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector should not hold callback from garbage collection. #130436

Merged
merged 15 commits into from
Jul 13, 2023
Merged

Inspector should not hold callback from garbage collection. #130436

merged 15 commits into from
Jul 13, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 12, 2023
@polina-c polina-c marked this pull request as ready for review July 12, 2023 19:31
@polina-c polina-c mentioned this pull request Jul 12, 2023
Open
jacob314
jacob314 reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once naming issue and testing issue are resolved.

jacob314
jacob314 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 13, 2023

auto label is removed for flutter/flutter, pr: 130436, due to - The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 13, 2023

auto label is removed for flutter/flutter, pr: 130436, due to - The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 13, 2023

auto label is removed for flutter/flutter, pr: 130436, due to - The status or check suite Linux skp_generator has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
def77be 
…flutter/flutter#130436)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
8d4ad29 
…flutter/flutter#130436)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
17483a5 
…flutter/flutter#130436)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
d3af6eb 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
966696d 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
6266e13 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
d74a5db 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
8810119 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
de8de2d 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
1b63e44 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
e76e45c 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
9cb59ab 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
e7f8471 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
7c398cd 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
99fd96a 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
add79e0 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
f419223 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
b762d40 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
4fbbbd6 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
3b1a489 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
310f922 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
08bf6ec 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
620c471 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
4c56167 
…flutter/flutter#130436)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
3c2cd015c Inspector should not hold callback from garbage collection. (…
e0fe6b0 
…flutter/flutter#130436)
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@polina-c @LouiseHsu
Inspector should not hold callback from garbage collection. (flutter#…
53d7d4f 
…130436)
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso left review comments

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polina-c @jacob314 @zanderso