Prevent `InputDecorator` from supplying its descendants with non-normalized constraints #130460

LongCatIsLooong · 2023-07-13T00:15:33Z

Fixes #129611

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…zed constraints

Renzo-Olivares

LGTM

Renzo-Olivares · 2023-07-17T18:06:36Z

packages/flutter/test/material/input_decorator_test.dart

@@ -6546,5 +6550,29 @@ void main() {
    // The prefix is inside the decorator.
    expect(decoratorRight, lessThanOrEqualTo(prefixRight));
  });
-}
+
+  testWidgets('InputDecotator with counter does not crash when given a 0 size', (WidgetTester tester) async {


nit: InputDecorator.

auto-submit · 2023-07-17T18:23:26Z

auto label is removed for flutter/flutter, pr: 130460, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-07-17T19:07:07Z

auto label is removed for flutter/flutter, pr: 130460, due to - The status or check suite Linux web_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…h non-normalized constraints (flutter/flutter#130460)

Roll Flutter from 6f09064e785b to d07e8aece184 (60 revisions) flutter/flutter@6f09064...d07e8ae 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09389b16d684 to eb2285205f25 (3 revisions) (flutter/flutter#130879) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0293a7cb7887 to 09389b16d684 (5 revisions) (flutter/flutter#130867) 2023-07-19 72562119+tgucio@users.noreply.github.com Move TapAndDragGestureRecognizer code under gestures (flutter/flutter#119508) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29de67c7d009 to 0293a7cb7887 (1 revision) (flutter/flutter#130858) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39d60be72ffb to 29de67c7d009 (4 revisions) (flutter/flutter#130855) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3bfc744bb61 to 39d60be72ffb (1 revision) (flutter/flutter#130847) 2023-07-19 engine-flutter-autoroll@skia.org Roll Flutter Engine from adf6142f6738 to b3bfc744bb61 (7 revisions) (flutter/flutter#130843) 2023-07-18 leroux_bruno@yahoo.fr Update app_builder_test.dart for M3 (flutter/flutter#130794) 2023-07-18 ian@hixie.ch Catch errors in loadStructuredData (flutter/flutter#130748) 2023-07-18 5236035+fzyzcjy@users.noreply.github.com Fix super tiny space formatting (hope we have auto formatter in the future) (flutter/flutter#127479) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 71bbecee3010 to adf6142f6738 (2 revisions) (flutter/flutter#130831) 2023-07-18 leroux_bruno@yahoo.fr Update SnackBar tests for M2/M3 (flutter/flutter#130717) 2023-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130821) 2023-07-18 thkim1011@users.noreply.github.com Relax syntax for gen-l10n (flutter/flutter#130736) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 45851af55bd6 to 71bbecee3010 (7 revisions) (flutter/flutter#130820) 2023-07-18 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130608) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 831da7e9dc3b to 45851af55bd6 (2 revisions) (flutter/flutter#130814) 2023-07-18 43054281+camsim99@users.noreply.github.com [Android] Deletes deprecated splash screen meta-data element (flutter/flutter#130744) 2023-07-18 hans.muller@gmail.com Updated `ThemeData.useMaterial3` API doc, default is `true` (flutter/flutter#130764) 2023-07-18 chillers@google.com [labeler] Mark sync-labels as empty (flutter/flutter#130642) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27658cc5ade to 831da7e9dc3b (2 revisions) (flutter/flutter#130810) 2023-07-18 engine-flutter-autoroll@skia.org Roll Packages from 6889cca to 3e8b813 (9 revisions) (flutter/flutter#130802) 2023-07-18 tessertaha@gmail.com Update `AppBar` and `AppBarTheme` tests for M2/M3 (flutter/flutter#130790) 2023-07-18 leroux_bruno@yahoo.fr Update app tests for M3 (flutter/flutter#130792) 2023-07-18 gspencergoog@users.noreply.github.com Add lint check to make sure samples are linked and have tests (flutter/flutter#130523) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from aaec42812a1f to c27658cc5ade (2 revisions) (flutter/flutter#130799) 2023-07-18 109111084+yaakovschectman@users.noreply.github.com Extract common functionality of iOS platformviews into superclasses (flutter/flutter#128716) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 88be39be7b07 to aaec42812a1f (1 revision) (flutter/flutter#130787) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b46a8baf8ed9 to 88be39be7b07 (1 revision) (flutter/flutter#130784) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 777fe158f4e7 to b46a8baf8ed9 (1 revision) (flutter/flutter#130782) 2023-07-18 tessertaha@gmail.com Fix `iconTheme` in `AppBar` doesn't apply custom `Colors.white` in the dark mode for M3 (flutter/flutter#130574) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c6e23288db8d to 777fe158f4e7 (2 revisions) (flutter/flutter#130779) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 116eedf769be to c6e23288db8d (3 revisions) (flutter/flutter#130778) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9d018f00d687 to 116eedf769be (2 revisions) (flutter/flutter#130774) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 77ec92371846 to 9d018f00d687 (1 revision) (flutter/flutter#130772) 2023-07-18 ian@hixie.ch Document stack's clipping behaviour better (flutter/flutter#130749) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from f2958f9229a4 to 77ec92371846 (1 revision) (flutter/flutter#130769) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3cceb705007e to f2958f9229a4 (1 revision) (flutter/flutter#130767) 2023-07-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 09689d37e1d6 to 3cceb705007e (2 revisions) (flutter/flutter#130763) 2023-07-18 flar@google.com Stabilize hybrid_android_views_integration_test rendering tree (flutter/flutter#130751) 2023-07-17 andrewrkolos@gmail.com update link to good first issues (flutter/flutter#130759) 2023-07-17 31859944+LongCatIsLooong@users.noreply.github.com Prevent `InputDecorator` from supplying its descendants with non-normalized constraints (flutter/flutter#130460) 2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 15c15fd75743 to 09689d37e1d6 (3 revisions) (flutter/flutter#130758) 2023-07-17 41930132+hellohuanlin@users.noreply.github.com [tools/ios_build_ipa] fallback to CFBundleName if CFBundleDisplayName is absent (flutter/flutter#130752) 2023-07-17 goderbauer@google.com Resolve TODOs in channels integration test (flutter/flutter#130745) 2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from ddbe23b374d8 to 15c15fd75743 (2 revisions) (flutter/flutter#130746) ...

…alized constraints (flutter#130460) Fixes flutter#129611

Prevent InputDecorator from supplying its descendant with non-normali…

affca56

…zed constraints

LongCatIsLooong requested a review from justinmc July 13, 2023 00:15

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 13, 2023

fix indentation

e6cde84

LongCatIsLooong changed the title ~~Prevent InputDecorator from supplying its descendant with non-normalized constraints~~ Prevent InputDecorator from supplying its descendants with non-normalized constraints Jul 13, 2023

LongCatIsLooong requested a review from Renzo-Olivares July 14, 2023 18:05

Renzo-Olivares approved these changes Jul 17, 2023

View reviewed changes

Update input_decorator_test.dart

e1bbcd0

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

Merge branch 'master' into input-decorator-zero-size

b4abd43

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

auto-submit bot merged commit fe7d01f into flutter:master Jul 17, 2023
73 checks passed

LongCatIsLooong deleted the input-decorator-zero-size branch July 17, 2023 23:37

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 203ef6f7a32f (111 revisions) flutter/packages#4503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

2a933a4

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 3b0b8348fd3e (112 revisions) flutter/packages#4505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

f5d2c6f

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 8b768de18f29 (113 revisions) flutter/packages#4506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

a5ded11

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

39ec5be

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to b460d49199e5 (115 revisions) flutter/packages#4508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

1202afe

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Manual roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4509

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

03d3d65

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 94179a8e3fd3 (116 revisions) flutter/packages#4510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

fa290fe

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to fc2626a790ae (117 revisions) flutter/packages#4512

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

a515017

…h non-normalized constraints (flutter/flutter#130460)

engine-flutter-autoroll mentioned this pull request Jul 19, 2023

Roll Flutter from 6f09064e785b to d07e8aece184 (60 revisions) flutter/packages#4522

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023

fe7d01ffa Prevent InputDecorator from supplying its descendants wit…

089ee6d

…h non-normalized constraints (flutter/flutter#130460)

HansMuller mentioned this pull request Jul 21, 2023

Flutter Framework Team: Notable Commits #121415

Open

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

Prevent InputDecorator from supplying its descendants with non-norm…

fe83b28

…alized constraints (flutter#130460) Fixes flutter#129611

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent `InputDecorator` from supplying its descendants with non-normalized constraints #130460

Prevent `InputDecorator` from supplying its descendants with non-normalized constraints #130460

LongCatIsLooong commented Jul 13, 2023

Renzo-Olivares left a comment

Renzo-Olivares Jul 17, 2023

auto-submit bot commented Jul 17, 2023

auto-submit bot commented Jul 17, 2023

Prevent InputDecorator from supplying its descendants with non-normalized constraints #130460

Prevent InputDecorator from supplying its descendants with non-normalized constraints #130460

Conversation

LongCatIsLooong commented Jul 13, 2023

Pre-launch Checklist

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Renzo-Olivares Jul 17, 2023

Choose a reason for hiding this comment

auto-submit bot commented Jul 17, 2023

auto-submit bot commented Jul 17, 2023

Prevent `InputDecorator` from supplying its descendants with non-normalized constraints #130460

Prevent `InputDecorator` from supplying its descendants with non-normalized constraints #130460