-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DropdownMenu
, SnackBarTheme
and Stepper
tests for M2/M3
#130464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
85546be
to
d7e17a3
Compare
expect(buttonMaterial(continueStr).color!.value, 0); | ||
expect(buttonMaterial(continueStr).textStyle!.color!.value, material3Light ? themeLight.colorScheme.onSurface.withOpacity(0.38).value : 0x61000000); | ||
expect(buttonMaterial(continueStr).textStyle!.color!.value, themeLight.colorScheme.onSurface.withOpacity(0.38).value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and similar lines are very long and exceed 80 characters maximum.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could get the button's Material in a variable once and check its properties instead of calling buttonMaterial(continueStr)
on every check and we can also make a colorScheme
variable instead of calling themeLight.colorScheme
on every check. This way it'd be readable and still fit in a single line.
Something like this:
expect(_buttonMaterial.color!.value, 0);
expect(_buttonMaterial.textStyle!.color!.value, _colorScheme.onSurface.withOpacity(0.38).value);
auto label is removed for flutter/flutter, pr: 130464, due to This PR has not met approval requirements for merging. Changes were requested by {TahaTesser}, please make the needed changes and resubmit this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…4518) Manual roll requested by stuartmorgan@google.com flutter/flutter@f842ed9...6f09064 2023-07-17 goderbauer@google.com Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 reidbaker@google.com Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 engine-flutter-autoroll@skia.org Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 tessertaha@gmail.com [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 pavel.mazhnik@gmail.com [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 tessertaha@gmail.com Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 36861262+QuncCccccc@users.noreply.github.com Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 ian@hixie.ch Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 ian@hixie.ch Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#130464) Updated unit tests for `DropdownMenu`, `SnackBarTheme` and `Stepper` to have M2 and M3 versions. More info in flutter#127064
Updated unit tests for
DropdownMenu
,SnackBarTheme
andStepper
to have M2 and M3 versions.More info in #127064
Pre-launch Checklist
///
).