Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use_emulator flag #130634

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Remove use_emulator flag #130634

merged 1 commit into from
Jul 14, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jul 14, 2023 •
edited
Loading

MInor cleanup to remove the use_emulator flag as adding the virtual device is enough to signal use of an emulator.

Land after https://flutter-review.googlesource.com/c/recipes/+/47341

List which issues are fixed by this PR. You must list at least one issue.
Fixes #130522

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

keyonghan
keyonghan approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a reminder to land this after the recipes CL.

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@auto-submit auto-submit bot merged commit 4d7bffe into flutter:master Jul 14, 2023
135 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
09a55fa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
e8f9e83
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
d50e02f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
97c19d9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
220c2a2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
1d0dec6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
159c902
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
d15112b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
62d0357
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
9c40b74
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
ee29c3d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
c4997b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
600511b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
caf0aac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
78ba87d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
2f53f50
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
44d02c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
87488bc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
a51f847
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
e9e4944
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
4d7bffe7f Remove use_emulator flag (flutter/flutter#130634)
9316984
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@ricardoamador @LouiseHsu
Remove use_emulator flag (flutter#130634)
de2e823 
MInor cleanup to remove the use_emulator flag as adding the virtual device is enough to signal use of an emulator.

Land after https://flutter-review.googlesource.com/c/recipes/+/47341

*List which issues are fixed by this PR. You must list at least one issue.*
Fixes flutter#130522

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@ricardoamador ricardoamador deleted the emulator_flag_130522 branch September 25, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan approved these changes

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the need for use emulator flag in emulator targets
2 participants
@ricardoamador @keyonghan