Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow OverlayPortal to be added/removed from the tree in a layout callback #130670

Merged
merged 1 commit into from Jul 17, 2023
Merged

Allow OverlayPortal to be added/removed from the tree in a layout callback #130670

merged 1 commit into from Jul 17, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

Fixes #130668

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 15, 2023
goderbauer
goderbauer approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023
@auto-submit auto-submit bot merged commit bf4d659 into flutter:master Jul 17, 2023
72 checks passed
@LongCatIsLooong LongCatIsLooong deleted the overlay-portal-fix-130668 branch July 17, 2023 17:48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
df70814 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
8eb57d8 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
9687f90 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
b74a697 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
7e7565c 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
75a7274 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
5dc61fd 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
de66d18 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
5814189 
…a layout callback (flutter/flutter#130670)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
2d6e4eb 
…a layout callback (flutter/flutter#130670)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023
@engine-flutter-autoroll
bf4d65972 Allow OverlayPortal to be added/removed from the tree in …
f0a936c 
…a layout callback (flutter/flutter#130670)
@LongCatIsLooong LongCatIsLooong mentioned this pull request Jul 20, 2023
Closed
@HansMuller HansMuller mentioned this pull request Jul 21, 2023
Open
LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Jul 25, 2023
@LongCatIsLooong
Allow OverlayPortal to be added/removed from the tree in a layout c…
f31edf5 
…allback (flutter#130670)

Fixes flutter#130668
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@LongCatIsLooong @LouiseHsu
Allow OverlayPortal to be added/removed from the tree in a layout c…
c116ffd 
…allback (flutter#130670)

Fixes flutter#130668
auto-submit bot pushed a commit that referenced this pull request Aug 7, 2023
@LongCatIsLooong
[CP] Allow OverlayPortal to be added/removed from the tree in a lay…
5c4bfbc 
…out callback (#130670) (#131290)

CP #131002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Regression) Scrolling away open Tooltips in a ListView causes a crash
2 participants
@LongCatIsLooong @goderbauer