-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest a potential valid name for the flutter project when using flutter create
#130900
Merged
auto-submit
merged 15 commits into
flutter:master
from
ValentinVignal:flutter-tools/suggest-a-potential-valid-name
Jul 21, 2023
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c374a23
feat: suggests a potential valid name
ValentinVignal 391d0f3
tests: update the tests
ValentinVignal 7af59bb
linter: Remove extra spaces
ValentinVignal a628767
bug: Replace unknown characters for all names
ValentinVignal 176aea3
fix: Add missing full stop
ValentinVignal a5de39d
refactor: Returns null if the name is not valid and only replace hyphens
ValentinVignal 14b2011
doc: Add more description to the error
ValentinVignal 00c28a1
test: Update the tests
ValentinVignal 19bf06f
Merge remote-tracking branch 'upstream/main' into flutter-tools/sugge…
ValentinVignal 79de8e9
docs: Remove redundant comment
ValentinVignal 57d0758
docs: Fix typo in test description
ValentinVignal 0dbc971
refactor: Put suggested name at the end of the message
ValentinVignal bcfa717
test: Update the tests
ValentinVignal 583a270
Merge remote-tracking branch 'upstream/main' into flutter-tools/sugge…
ValentinVignal e82a902
lint: Remove trailing space
ValentinVignal File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also put the rules directly into the output so the user have to leave their terminal. I doubt these rules would ever change, so we don't have to worry about them becoming out of date.
However, I think just having a link is also sufficient 👍 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the instructions in doc: Add more description to the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
If we do include the rules and the link, I think we should include the suggested name last. The suggested name is the least important information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I changed the order in refactor: Put suggested name at the end of the message