Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageDecoration.lerp (#130533) #131349

Merged
merged 1 commit into from Jul 26, 2023
Merged

ImageDecoration.lerp (#130533) #131349

merged 1 commit into from Jul 26, 2023

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Jul 26, 2023

This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for clampDouble instead of duplicating it in package:foundation.

Fixes #12452

This was first landed in #130533 and reverted in #131347.

This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter#12452
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 26, 2023
@Hixie Hixie marked this pull request as ready for review July 26, 2023 20:39
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2023
@auto-submit auto-submit bot merged commit 33e9fd8 into flutter:master Jul 26, 2023
72 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
tarrinneal pushed a commit to flutter/packages that referenced this pull request Jul 27, 2023
…4572)

Manual roll requested by tarrinneal@google.com

flutter/flutter@bae1ac2...61fd11d

2023-07-26 737941+loic-sharma@users.noreply.github.com Add the 'a:
desktop' label to labeler.yml (flutter/flutter#130933)
2023-07-26 ian@hixie.ch ImageDecoration.lerp (#130533)
(flutter/flutter#131349)
2023-07-26 katelovett@google.com Minor adjustments on 2D APIs
(flutter/flutter#131358)
2023-07-26 737941+loic-sharma@users.noreply.github.com Revert "Update
Unit Tests for M2/M3" (flutter/flutter#131368)
2023-07-26 36861262+QuncCccccc@users.noreply.github.com Update Unit
Tests for M2/M3 (flutter/flutter#131292)
2023-07-26 737941+loic-sharma@users.noreply.github.com Revert "Run
benchmarks with `--omit-type-checks`" (flutter/flutter#131353)
2023-07-26 ian@hixie.ch Revert "ImageDecoration.lerp"
(flutter/flutter#131347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter#12452

This was first landed in flutter#130533 and reverted in flutter#131347.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter#12452

This was first landed in flutter#130533 and reverted in flutter#131347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DecorationImage - lerp and scale
2 participants