Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DropdownButtonFormField input border clipping #131481

Merged
merged 3 commits into from Aug 10, 2023
Merged

Fix DropdownButtonFormField input border clipping #131481

merged 3 commits into from Aug 10, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Jul 28, 2023 •
edited

fixes BUG: DropdownButtonFormField input decorator focus/hover is not clipped

Description

This fixes an issue where DropdownButtonFormField's input border isn't used for clipping with InkWell.

Before

Screenshot 2023-07-28 at 17 06 20

After

Screenshot 2023-07-28 at 17 06 38

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 28, 2023
@HansMuller HansMuller removed their request for review July 28, 2023 17:34
@TahaTesser TahaTesser force-pushed the fix_dropdown_form_field_clip branch from 1b81735 to 503b694 Compare July 31, 2023 12:16
QuncCccccc
QuncCccccc approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spent some time on investigating this issue. Sorry for the late response. LGTM:)

@TahaTesser TahaTesser force-pushed the fix_dropdown_form_field_clip branch 2 times, most recently from 427286c to a6fd7b9 Compare August 9, 2023 17:51
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit auto-submit bot merged commit bb6b72d into flutter:master Aug 10, 2023
67 checks passed
@TahaTesser TahaTesser deleted the fix_dropdown_form_field_clip branch August 10, 2023 08:37
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
2b2151b 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
f71f7bc 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
75631fd 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
68be3da 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
c861f0a 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
9139287 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
a4992fd 
…r/flutter#131481)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
4825740 
…r/flutter#131481)
@HansMuller HansMuller mentioned this pull request Aug 11, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
bb6b72d6c Fix DropdownButtonFormField input border clipping (flutte…
d6edf85 
…r/flutter#131481)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navaronbracke navaronbracke navaronbracke left review comments

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: DropdownButtonFormField input decorator focus/hover is not clipped
3 participants
@TahaTesser @navaronbracke @QuncCccccc