Sample code for ImageProvider #131952
Merged
Sample code for ImageProvider #131952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
a: tests
Hixie
force-pushed
the
imageprovider
branch
4 times, most recently
from
9cdd279
to
b45c51d
Compare
goderbauer
approved these changes
Aug 8, 2023
Comment on lines
24
to
27
| if (configuration.platform == null) | ||
| 'platform': null.toString(), | ||
| if (configuration.platform != null) | ||
| 'platform': configuration.platform!.toString().substring('$TargetPlatform'.length + 1), |
There was a problem hiding this comment.
Isn't configuration.platform an enum so this could be simplified to:
Suggested change
| if (configuration.platform == null) | |
| 'platform': null.toString(), | |
| if (configuration.platform != null) | |
| 'platform': configuration.platform!.toString().substring('$TargetPlatform'.length + 1), | |
| 'platform': configuration.platform?.name ?? null.toString(), |
There was a problem hiding this comment.
oh I always forget about EnumName because it's not in the API docs for Enum
There was a problem hiding this comment.
Right! Send a PR to add it? ;)
There was a problem hiding this comment.
it simplified even more than you suggested, heh
There was a problem hiding this comment.
Submitted dart-lang/sdk#53164 for the Enum doc issue.
Comment on lines
30
to
35
| if (configuration.textDirection == null) | ||
| 'bidi': null.toString(), | ||
| if (configuration.textDirection == TextDirection.ltr) | ||
| 'bidi': 'ltr', | ||
| if (configuration.textDirection == TextDirection.rtl) | ||
| 'bidi': 'rtl', |
There was a problem hiding this comment.
Suggested change
| if (configuration.textDirection == null) | |
| 'bidi': null.toString(), | |
| if (configuration.textDirection == TextDirection.ltr) | |
| 'bidi': 'ltr', | |
| if (configuration.textDirection == TextDirection.rtl) | |
| 'bidi': 'rtl', | |
| 'bidi': configuration.textDirection?.name ?? null.toString(), |
| debugPrint('Fetching "$key"...'); | ||
| return MultiFrameImageStreamCompleter( | ||
| codec: | ||
| _httpClient.getUrl(key) |
There was a problem hiding this comment.
nit: formatting here seems off. Maybe move this to the previous line (or indent the .then lines further)?
|
auto label is removed for flutter/flutter/131952, due to - The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
Also: - minor improvements to documentation - wrap one of our test error messages in a manner more consistent with other messages
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: