Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextPainter migration cleanup #132317

Merged
merged 1 commit into from Aug 10, 2023
Merged

TextPainter migration cleanup #132317

merged 1 commit into from Aug 10, 2023

Conversation

LongCatIsLooong
Copy link
Contributor

Undo temporary changes made in #132094

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Aug 10, 2023
justinmc
justinmc approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2023
@auto-submit auto-submit bot merged commit e1fd2ac into flutter:master Aug 10, 2023
139 checks passed
@LongCatIsLooong LongCatIsLooong deleted the rounding-hack-cleanup branch August 10, 2023 20:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
e1fd2ace9 TextPainter migration cleanup (flutter/flutter#132317)
3ce9048
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
e1fd2ace9 TextPainter migration cleanup (flutter/flutter#132317)
38c5fde
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 11, 2023
@engine-flutter-autoroll
Roll Flutter from 685141bf3b5f to 9b6945b465a1 (25 revisions) (#4680)
ec83969 
flutter/flutter@685141b...9b6945b

2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 93e8901490e7 to 77dfeea40e10 (1 revision) (flutter/flutter#132389)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e532b957225 to 93e8901490e7 (1 revision) (flutter/flutter#132381)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25afdb9b696d to 4e532b957225 (4 revisions) (flutter/flutter#132376)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from da23fb0d9a1d to 25afdb9b696d (1 revision) (flutter/flutter#132370)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from acd1bc5536ef to da23fb0d9a1d (2 revisions) (flutter/flutter#132367)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 578a8e8aabf6 to acd1bc5536ef (1 revision) (flutter/flutter#132365)
2023-08-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 18a71c031f5f to 578a8e8aabf6 (1 revision) (flutter/flutter#132364)
2023-08-11 matanlurey@users.noreply.github.com Update `dev/devicelab/**` to provide `--local-engine-host`. (flutter/flutter#132342)
2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from b019ac62f21f to 18a71c031f5f (2 revisions) (flutter/flutter#132347)
2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 16b01b98af20 to b019ac62f21f (1 revision) (flutter/flutter#132341)
2023-08-10 matanlurey@users.noreply.github.com Update `flutter_tools/bin/*.(dart|sh)` to provide, if set, --local-engine-host. (flutter/flutter#132336)
2023-08-10 47866232+chunhtai@users.noreply.github.com Update application id and bundle id of a11y assessment app (flutter/flutter#132334)
2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9be77e6f475 to 16b01b98af20 (6 revisions) (flutter/flutter#132332)
2023-08-10 ian@hixie.ch Remove the fast reassemble / single widget reload feature (flutter/flutter#132255)
2023-08-10 goderbauer@google.com Analyze code snippets in integration_test docs (flutter/flutter#132314)
2023-08-10 109253501+pdblasi-google@users.noreply.github.com Adds SemanticsNode Finders for searching the semantics tree (flutter/flutter#127137)
2023-08-10 rmolivares@renzo-olivares.dev TextField should correctly resolve provided style for material states (flutter/flutter#132330)
2023-08-10 ian@hixie.ch setState documentation (flutter/flutter#132090)
2023-08-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from ea7730c16301 to a9be77e6f475 (6 revisions) (flutter/flutter#132328)
2023-08-10 75845003+deldering-momo@users.noreply.github.com Fix: use --web-launch-url and --web-hostname arguments in flutter drive (flutter/flutter#131763)
2023-08-10 ian@hixie.ch GridView sample code (flutter/flutter#131900)
2023-08-10 polinach@google.com Upgrade flutter packages. (flutter/flutter#132326)
2023-08-10 31859944+LongCatIsLooong@users.noreply.github.com TextPainter migration cleanup (flutter/flutter#132317)
2023-08-10 ian@hixie.ch An example of parentData usage. (flutter/flutter#131818)
2023-08-10 dumazy@gmail.com Add hasInteractedByUser getter in FormField (flutter/flutter#131539)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e1fd2ace9 TextPainter migration cleanup (flutter/flutter#132317)
3d4919b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LongCatIsLooong @justinmc