New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read --dart-define
in RendererBinding.initInstances()
#132408
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
doing it in a constructor seems like it would mean we're doing it more than once, when we only need to do it once, right? would the binding be a better place for it maybe? |
--dart-define
in TextPainter initializer list--dart-define
in RendererBinding.initInstances()
Can you leave a pointer to the documentation of what this is? Just so we can follow the breadcrumb trail if someone new needs to clean this up later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0830506
to
ee2b8d6
Compare
Move
SKPARAGRAPH_REMOVE_ROUNDING_HACK
reading to the framework fromdart:ui
soflutter run --dart-define="SKPARAGRAPH_REMOVE_ROUNDING_HACK=false"
worksPre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.