Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the keyboard manager protocol #132533

Merged
merged 1 commit into from Aug 15, 2023
Merged

Explain the keyboard manager protocol #132533

merged 1 commit into from Aug 15, 2023

Conversation

dkwingsmt
Copy link
Contributor

Fixes #132433

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 14, 2023
@dkwingsmt dkwingsmt mentioned this pull request Aug 14, 2023
Closed
2 tasks
@goderbauer goderbauer requested a review from Piinks August 15, 2023 22:05
@Piinks Piinks added the d: api docs Issues with https://api.flutter.dev/ label Aug 15, 2023
Piinks
Piinks approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2023
@auto-submit auto-submit bot merged commit 6971dcb into flutter:master Aug 15, 2023
73 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
6971dcb70 Explain the keyboard manager protocol (flutter/flutter#132533)
e2ac85b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 16, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
6971dcb70 Explain the keyboard manager protocol (flutter/flutter#132533)
2a50095
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
Roll Flutter from f0e7c5181641 to 2502b51f86c1 (15 revisions) (#4722)
63ba60c 
flutter/flutter@f0e7c51...2502b51

2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (flutter/flutter#132655)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (flutter/flutter#132649)
2023-08-16 whesse@google.com Fix flutter_tools use of --local-engine-host (flutter/flutter#132648)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (flutter/flutter#132623)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (flutter/flutter#132621)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (flutter/flutter#132618)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (flutter/flutter#132612)
2023-08-16 jonahwilliams@google.com Revert "Reorganize and clarify API doc generator" (flutter/flutter#132613)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) (flutter/flutter#132609)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) (flutter/flutter#132608)
2023-08-16 tessertaha@gmail.com [Reland] #131609 (flutter/flutter#132555)
2023-08-15 dkwingsmt@users.noreply.github.com Explain the keyboard manager protocol (flutter/flutter#132533)
2023-08-15 katelovett@google.com Fix extent for null returning builder in GridView (flutter/flutter#132511)
2023-08-15 gspencergoog@users.noreply.github.com Reorganize and clarify API doc generator (flutter/flutter#132353)
2023-08-15 gspencergoog@users.noreply.github.com Fixing a memory leak in About box/dialog overlays (flutter/flutter#130842)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Aug 25, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
6971dcb70 Explain the keyboard manager protocol (flutter/flutter#132533)
58c2de6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FlutterEngineSendKeyEvent only sends message to the flutter/keydata channel after a flutter/keyevent message
2 participants
@dkwingsmt @Piinks