Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up analytics opt in/out flags #132588

Merged
merged 9 commits into from Sep 12, 2023
Merged

Clean up analytics opt in/out flags #132588

merged 9 commits into from Sep 12, 2023

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Aug 15, 2023 •
edited

Fixes:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eliasyishak eliasyishak linked an issue Aug 15, 2023 that may be closed by this pull request
Clean up commands for analytics opt out #132258
Closed
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 15, 2023
@eliasyishak eliasyishak requested a review from Hixie August 15, 2023 21:34
@eliasyishak eliasyishak mentioned this pull request Aug 15, 2023
Merged
1 task
@eliasyishak eliasyishak marked this pull request as draft August 24, 2023 20:15
@eliasyishak eliasyishak marked this pull request as ready for review September 11, 2023 16:25
@eliasyishak
Copy link
Contributor Author

@Hixie this PR is now ready for a review now that the PDD has been updated to change the text around the flag we use.

Hixie
Hixie reviewed Sep 11, 2023
View reviewed changes
packages/flutter_tools/lib/src/commands/config.dart
@@ -15,7 +15,8 @@ import '../runner/flutter_command.dart';
class ConfigCommand extends FlutterCommand {
ConfigCommand({ bool verboseHelp = false }) {
argParser.addFlag('analytics',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to hide this one by default, since it's redundant with the other ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea, i have hidden it so that it only shows up when running in verbose mode

Hixie
Hixie approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the minor comments above

@eliasyishak eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023
@auto-submit auto-submit bot merged commit e9beaea into flutter:master Sep 12, 2023
120 checks passed
@eliasyishak eliasyishak deleted the 132258-clean-up-commands-for-analytics-opt-out branch September 12, 2023 22:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
167a136
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
98514a0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
ae97b05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
06fb0dc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
1443b41
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@eliasyishak @Mairramer
Clean up analytics opt in/out flags (flutter#132588)
79f403e 
Fixes:
- flutter#132258
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
e9beaea06 Clean up analytics opt in/out flags (flutter/flutter#132588)
6e80cab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up commands for analytics opt out
2 participants
@eliasyishak @Hixie