Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ExpansionPanel example for the updated expansionCallback callback #132837

Merged
merged 1 commit into from Aug 21, 2023
Merged

Update ExpansionPanel example for the updated expansionCallback callback #132837

merged 1 commit into from Aug 21, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Aug 18, 2023 •
edited

fixes ExpansionPanelList can't expand/collapse on the latest stable/master

#128082 updated the expansionCallback and also the ExpansionPanel sample in the Flutter gallery but not the API example.

This PR fixes the API example and adds tests.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 18, 2023
@TahaTesser TahaTesser force-pushed the update_expansionPanelList_example branch from 6345cd7 to 1e83690 Compare August 18, 2023 15:06
@TahaTesser TahaTesser requested a review from Piinks August 18, 2023 15:24
@TahaTesser TahaTesser mentioned this pull request Aug 19, 2023
Closed
2 tasks
@TahaTesser TahaTesser force-pushed the update_expansionPanelList_example branch from 1e83690 to 9613d0f Compare August 21, 2023 12:47
Piinks
Piinks approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM
Thanks for getting another code sample tested! It would have caught this breakage ahead of time. Now we are covered. :)

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2023
@auto-submit auto-submit bot merged commit af79b4c into flutter:master Aug 21, 2023
140 checks passed
@TahaTesser TahaTesser deleted the update_expansionPanelList_example branch August 21, 2023 20:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
af79b4c7a Update ExpansionPanel example for the updated `expansionC…
758ca46 
…allback` callback (flutter/flutter#132837)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 22, 2023
@engine-flutter-autoroll
Roll Flutter from 5e6d88d766b9 to 54c98d7433c5 (24 revisions) (#4754)
c730a90 
flutter/flutter@5e6d88d...54c98d7

2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 447981acbf36 to f5f099a4a5e3 (1 revision) (flutter/flutter#133035)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e84d733ef67 to 447981acbf36 (2 revisions) (flutter/flutter#133031)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from e183e8a94093 to 5e84d733ef67 (1 revision) (flutter/flutter#133030)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 454e0e35f8e4 to e183e8a94093 (2 revisions) (flutter/flutter#133026)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 857840db5574 to 454e0e35f8e4 (1 revision) (flutter/flutter#133020)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1ab054967c1d to 857840db5574 (2 revisions) (flutter/flutter#133018)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5a292e42a593 to 1ab054967c1d (1 revision) (flutter/flutter#133014)
2023-08-22 katelovett@google.com Fix visual overflow for SliverMainAxisGroup (flutter/flutter#132989)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5929d83e9b7 to 5a292e42a593 (3 revisions) (flutter/flutter#133010)
2023-08-22 matanlurey@users.noreply.github.com Always require `--local-engine-host` if `--local-engine` (flutter/flutter#133003)
2023-08-22 engine-flutter-autoroll@skia.org Roll Flutter Engine from 55b84268f2a6 to e5929d83e9b7 (3 revisions) (flutter/flutter#133005)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e5f690b829e5 to 55b84268f2a6 (1 revision) (flutter/flutter#133000)
2023-08-21 angelosilvestre.ccp@gmail.com Add deleteBackwardByDecomposingPreviousCharacter mapping for tests (flutter/flutter#132919)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc75109c3a1e to e5f690b829e5 (1 revision) (flutter/flutter#132996)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2388b9db2be7 to fc75109c3a1e (3 revisions) (flutter/flutter#132992)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 210f5a8aa245 to 2388b9db2be7 (6 revisions) (flutter/flutter#132986)
2023-08-21 tessertaha@gmail.com  Update `ExpansionPanel` example for the updated `expansionCallback` callback (flutter/flutter#132837)
2023-08-21 34871572+gmackall@users.noreply.github.com Change gradle lockfile generation script to use --config-only flag (flutter/flutter#132967)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0290d0bd79ee to 210f5a8aa245 (1 revision) (flutter/flutter#132973)
2023-08-21 jmccandless@google.com Docs on iOS's directional quote characters (flutter/flutter#132869)
2023-08-21 reidbaker@google.com Bump memory usage for flutter gallery (flutter/flutter#132968)
2023-08-21 5236035+fzyzcjy@users.noreply.github.com When resized network image has error, all future unrelated images using the same url will fail, even if the network becomes OK (flutter/flutter#127456)
2023-08-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a9b00783bc7c to 0290d0bd79ee (1 revision) (flutter/flutter#132962)
2023-08-21 engine-flutter-autoroll@skia.org Roll Packages from 4c16f3e to e26f3b9 (5 revisions) (flutter/flutter#132960)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@TahaTesser TahaTesser mentioned this pull request Aug 24, 2023
Open
@huycozy huycozy mentioned this pull request Aug 24, 2023
Closed
2 tasks
@huycozy huycozy mentioned this pull request Oct 20, 2023
Closed
@blueeyestw
Copy link

Hi, anyone know how long until this fix lands in stable channel? It's still returning the wrong boolean state in version 3.13.8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
af79b4c7a Update ExpansionPanel example for the updated `expansionC…
c50653b 
…allback` callback (flutter/flutter#132837)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpansionPanelList can't expand/collapse on the latest stable/master
3 participants
@TahaTesser @blueeyestw @Piinks