Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry connecting to device in CI after lost connection #133769

Merged
merged 5 commits into from Sep 5, 2023
Merged

Retry connecting to device in CI after lost connection #133769

merged 5 commits into from Sep 5, 2023

Conversation

vashworth
Copy link
Contributor

@vashworth vashworth commented Aug 31, 2023 •
edited

Sometimes ios-deploy loses connection to the device after installing, starting debugserver, and launching. This is shown with an error message like:

Process 579 exited with status = -1 (0xffffffff) lost connection

This happens frequently in our CI system: #120808

Usually in CI, on retry it'll work and pass - so this is an attempt to retry without failing the test first. It's not guaranteed to fix since we're unable to recreate this error locally.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 31, 2023
@vashworth vashworth marked this pull request as ready for review August 31, 2023 17:53
@vashworth
Copy link
Contributor Author

Google testing seems to be failing on something unrelated. I tried clicking "Re-run" but hasn't done anything yet. I'll give it a little time and if not, I'll update the branch to trigger it to rerun.

christopherfujino
christopherfujino reviewed Aug 31, 2023
View reviewed changes
packages/flutter_tools/lib/src/ios/devices.dart
portForwarder: isWirelesslyConnected ? null : portForwarder,
hostPort: debuggingOptions.hostVmServicePort,
devicePort: debuggingOptions.deviceVmServicePort,
vmServiceDiscovery = _setupDebuggerAndVmServiceDiscovery(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a cursory look, this diff doesn't change anything, just factors out the left side logic to a helper method, is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much, only difference is I added a skipInstall option

christopherfujino
christopherfujino approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Member

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

@vashworth
Copy link
Contributor Author

BTW, your google testing failure looks like a bug with FRoB. I chatted with the release team who is on it, I think they are going to put out a PSA soon.

Thanks for the heads up!

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@auto-submit auto-submit bot merged commit 6c56421 into flutter:master Sep 5, 2023
120 checks passed
@vashworth vashworth mentioned this pull request Sep 5, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
37c2a1a 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
7d40014 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
998356e 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
5e3f3cc 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
0882ec8 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
2c7e686 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
c76bde6 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
ef8d561 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
62f4831 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
8e37c2c 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
1d22bb1 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
c8def9c 
…tter/flutter#133769)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
139f909 
…tter/flutter#133769)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
3192f32 
…tter/flutter#133769)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
6c5642167 Retry connecting to device in CI after lost connection (flu…
1249e4d 
…tter/flutter#133769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vashworth @christopherfujino