Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Mac_arm64_ios run_debug_test_macos in presubmit #133788

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Run Mac_arm64_ios run_debug_test_macos in presubmit #133788

merged 1 commit into from
Aug 31, 2023

Conversation

vashworth
Copy link
Contributor

Fixes #118830.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth vashworth mentioned this pull request Aug 31, 2023
Closed
@vashworth
Copy link
Contributor Author

vashworth commented Aug 31, 2023 •
edited

@yusuf-goog Looks like https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-38 is failing to install Xcode with error:

[E 2023-08-31 11:41:19] original error: Developer mode is currently disabled! Please use `sudo /usr/sbin/DevToolsSecurity -enable` to enable.

Is it expected to be enabled?

@yusuf-goog
Copy link
Contributor 

flutter@flutter-devicelab-mac-38 ~ % sudo /usr/sbin/DevToolsSecurity -enable
Password:
Developer mode is now enabled.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 31, 2023
@auto-submit auto-submit bot merged commit 8128b2e into flutter:master Aug 31, 2023
133 checks passed
@yusuf-goog yusuf-goog mentioned this pull request Aug 31, 2023
Closed
vashworth added a commit that referenced this pull request Aug 31, 2023
@vashworth
Revert "Run Mac_arm64_ios run_debug_test_macos in presubmit (#133788)"
16fda89 
This reverts commit 8128b2e.
@vashworth vashworth mentioned this pull request Aug 31, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request Aug 31, 2023
@vashworth
Revert "Run Mac_arm64_ios run_debug_test_macos in presubmit" (#133808)
e98d392 
Reverts #133788

Something is wrong with bot https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-38, it's unable to open the project in Xcode. Failing consistently. 

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771213845302282993/+/u/ios_debug_symbol_doctor/recover_with_120_second_timeout/stdout

So reverting until we can get the bot fixed.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
bdbdf6d 
…r/flutter#133788)
@vashworth vashworth mentioned this pull request Sep 1, 2023
Merged
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
3d1195c 
…r/flutter#133788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
473f85b 
…r/flutter#133788)
auto-submit bot pushed a commit that referenced this pull request Sep 1, 2023
@vashworth
Run Mac_arm64_ios run_debug_test_macos in presubmit (#133869)
37c55ba 
Reland #133788.

Fixes #118830.
Fixes #125342.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
86e3c39 
…r/flutter#133788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
06d4904 
…r/flutter#133788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
60e5dfc 
…r/flutter#133788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
5057fef 
…r/flutter#133788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
9411ff3 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
c34a126 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
7fb45ca 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
6904e2b 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
4ddfa8e 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
292e55a 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
72fc2d0 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
db67dcb 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
4488f0d 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
13625e2 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
e41d7e7 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
a538578 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
d3d94a9 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
63a3e1a 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
7abaaf3 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
11131a8 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
8742c8a 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
bcef64e 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
1a34f03 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
0713394 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
d4cc5ad 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
6bdf402 
…r/flutter#133788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
8128b2e2f Run Mac_arm64_ios run_debug_test_macos in presubmit (flutte…
69cdcc5 
…r/flutter#133788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Mac_arm64_ios run_debug_test_macos in presubmit after iPhone 11 migration is complete
2 participants
@vashworth @yusuf-goog