Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_MaterialAppState should dispose MaterialHeroController. #133951

Merged
merged 8 commits into from Sep 5, 2023
Merged

_MaterialAppState should dispose MaterialHeroController. #133951

merged 8 commits into from Sep 5, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 3, 2023

No description provided.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 3, 2023
@polina-c polina-c mentioned this pull request Sep 3, 2023
Closed
@polina-c polina-c marked this pull request as ready for review September 4, 2023 02:02
chunhtai
chunhtai approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/widgets/heroes.dart Outdated Show resolved Hide resolved
packages/flutter/lib/src/material/app.dart Show resolved Hide resolved
@polina-c @chunhtai
Update packages/flutter/lib/src/widgets/heroes.dart
089768c 
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
@polina-c polina-c mentioned this pull request Sep 5, 2023
Closed
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 5, 2023

auto label is removed for flutter/flutter/133951, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@polina-c polina-c merged commit 7625c10 into flutter:master Sep 5, 2023
67 checks passed
@polina-c polina-c deleted the _MaterialAppState branch September 5, 2023 20:41
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
ae28c5c 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
91dec0e 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
3bc9b6d 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
b3820e6 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
6566537 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
685c1bf 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
ebb060e 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
eb5dcff 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
76ee8ca 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
39296f0 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
bc6b561 
…lutter/flutter#133951)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
cf8a010 
…lutter/flutter#133951)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
12ace66 
…lutter/flutter#133951)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
ce28979 
…lutter/flutter#133951)
@HansMuller HansMuller mentioned this pull request Sep 8, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
7625c10f4 _MaterialAppState should dispose MaterialHeroController. (f…
422875c 
…lutter/flutter#133951)
@ValentinVignal ValentinVignal mentioned this pull request Mar 11, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@polina-c @chunhtai