Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reland] Fix flavors test install checks #134060

Merged
merged 6 commits into from
Sep 5, 2023
Merged

[Reland] Fix flavors test install checks #134060

merged 6 commits into from
Sep 5, 2023

Conversation

andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented Sep 5, 2023 •
edited
Loading

Reland of #133719. Updates the string comparison in flavor_test.dart to use path.join to build the path string so that the generated path is correct for both Linux and Windows hosts.

Fixes #133713

I've tested this on a Windows host targeting a physical Android device.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@andrewkolos andrewkolos changed the title Fix flavors test install checks [Reland] Fix flavors test install checks Sep 5, 2023
christopherfujino
christopherfujino approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 5, 2023
@auto-submit auto-submit bot merged commit c05dc3e into flutter:master Sep 5, 2023
131 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
49fb71c 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
9208284 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
6d4a31d 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
e0aa3f9 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
6e860d8 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
3cee3c6 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
af08444 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
a3165cb 
…34060)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
52bee9d 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
5ccac3d 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
83bc1df 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
58f3161 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
571e340 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
c6b5d14 
…34060)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
c05dc3e68 [Reland] Fix flavors test install checks (flutter/flutter#1…
7a85ccd 
…34060)
@andrewkolos andrewkolos deleted the fix-flavors_test-install-checks branch April 29, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devicelab test for flutter install with an invalid --flavor cannot fail
2 participants
@andrewkolos @christopherfujino