New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover more test/widgets tests with leak tracking #2 #134387
Conversation
cc @polina-c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Couple comments.
packages/flutter/test/widgets/editable_text_show_on_screen_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more comments.
@polina-c I live in the CET timezone, so I will continue to work on this PR tomorrow (Monday). |
@ksokolovskyi , is it ready for next round of review? |
@polina-c yes, could you please take a look again? |
packages/flutter/test/widgets/editable_text_show_on_screen_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/134387, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Description
This PR changes
testWidgets
bytestWidgetsWithLeakTracking
in number offlutter/test/widgets
tests according to the dart-lang/leak_tracker#134.Marks leaks
Tests
draggable_test.dart
to usetestWidgetsWithLeakTracking
;drawer_test.dart
to usetestWidgetsWithLeakTracking
;dual_transition_builder_test.dart
to usetestWidgetsWithLeakTracking
;editable_text_cursor_test.dart
to usetestWidgetsWithLeakTracking
;editable_text_shortcuts_test.dart
to usetestWidgetsWithLeakTracking
;editable_text_show_on_screen_test.dart
to usetestWidgetsWithLeakTracking
;editable_text_test.dart
to usetestWidgetsWithLeakTracking
;ensure_visible_test.dart
to usetestWidgetsWithLeakTracking
;error_widget_builder_test.dart
to usetestWidgetsWithLeakTracking
;fade_in_image_test.dart
to usetestWidgetsWithLeakTracking
;fade_transition_test.dart
to usetestWidgetsWithLeakTracking
;fitted_box_test.dart
to usetestWidgetsWithLeakTracking
;flex_test.dart
to usetestWidgetsWithLeakTracking
;flow_test.dart
to usetestWidgetsWithLeakTracking
.Pre-launch Checklist
///
).