Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated TextSelectionOverlay.fadeDuration #134485

Merged
merged 1 commit into from Sep 12, 2023
Merged

Remove deprecated TextSelectionOverlay.fadeDuration #134485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/flutter/lib/src/widgets/text_selection.dart
View file
Open in desktop
Expand Up @@ -374,13 +374,6 @@ class TextSelectionOverlay {
/// {@endtemplate}
final BuildContext context;

/// Controls the fade-in and fade-out animations for the toolbar and handles.
@Deprecated(
'Use `SelectionOverlay.fadeDuration` instead. '
'This feature was deprecated after v2.12.0-4.1.pre.'
)
static const Duration fadeDuration = SelectionOverlay.fadeDuration;

// TODO(mpcomplete): what if the renderObject is removed or replaced, or
// moves? Not sure what cases I need to handle, or how to handle them.
/// The editable line in which the selected text is being displayed.
Expand Down
4 changes: 0 additions & 4 deletions packages/flutter/test/widgets/text_selection_test.dart
View file
Open in desktop
Expand Up @@ -99,10 +99,6 @@ void main() {
);
}

test('TextSelectionOverlay.fadeDuration exist', () async {
expect(TextSelectionOverlay.fadeDuration, SelectionOverlay.fadeDuration);
});

testWidgets('a series of taps all call onTaps', (WidgetTester tester) async {
await pumpGestureDetector(tester);
await tester.tapAt(const Offset(200, 200));
Expand Down