Enabled flutter_tools tests that were previously disabled on Windows.

dev/bots/test.dart

@@ -326,7 +326,7 @@ Future<Null> _runFlutterTest(String workingDirectory, {
     workingDirectory: workingDirectory,
     expectFailure: expectFailure,
     printOutput: printOutput,
-    skip: skip || Platform.isWindows, // TODO(goderbauer): run on Windows when sky_shell is available
+    skip: skip,
   );
 }
 

packages/flutter/test/animation/tween_test.dart

@@ -63,8 +63,8 @@ void main() {
     );
     final Matrix4 c = a.clone()..rotateZ(1.0);
     final Matrix4Tween rotationTween = new Matrix4Tween(begin: a, end: c);
-    expect(rotationTween.lerp(0.0), equals(a));
-    expect(rotationTween.lerp(1.0), equals(c));
+    expect(rotationTween.lerp(0.0).absoluteError(a), moreOrLessEquals(0.0));
+    expect(rotationTween.lerp(1.0).absoluteError(c), moreOrLessEquals(0.0));
     expect(
       rotationTween.lerp(0.5).absoluteError(
         a.clone()..rotateZ(0.5)

packages/flutter/test/foundation/error_reporting_test.dart

@@ -7,6 +7,8 @@ import 'dart:async';
 import 'package:flutter/foundation.dart';
 import 'package:test/test.dart';
 
+import 'platform_utils.dart';
+
 dynamic getAssertionErrorWithMessage() {
   try {
     assert(false, 'Message goes here.');
@@ -62,7 +64,7 @@ Future<Null> main() async {
         information.writeln('line 2 of extra information\n'); // the double trailing newlines here are intentional
       },
     ));
-    expect(console.join('\n'), matches(new RegExp(
+    expect(sanitizePaths(console.join('\n')), matches(new RegExp(
       '^══╡ EXCEPTION CAUGHT BY ERROR HANDLING TEST ╞═══════════════════════════════════════════════════════\n'
       'The following assertion was thrown testing the error handling logic:\n'
       'Message goes here\\.\n'
@@ -99,7 +101,7 @@ Future<Null> main() async {
     FlutterError.dumpErrorToConsole(new FlutterErrorDetails(
       exception: getAssertionErrorWithLongMessage(),
     ));
-    expect(console.join('\n'), matches(new RegExp(
+    expect(sanitizePaths(console.join('\n')), matches(new RegExp(
       '^══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════\n'
       'The following assertion was thrown:\n'
       'word word word word word word word word word word word word word word word word word word word word '
@@ -144,7 +146,7 @@ Future<Null> main() async {
         information.writeln('line 2 of extra information\n'); // the double trailing newlines here are intentional
       },
     ));
-    expect(console.join('\n'), matches(new RegExp(
+    expect(sanitizePaths(console.join('\n')), matches(new RegExp(
       '^══╡ EXCEPTION CAUGHT BY ERROR HANDLING TEST ╞═══════════════════════════════════════════════════════\n'
       'The following assertion was thrown testing the error handling logic:\n'
       '\'[^\']+flutter/test/foundation/error_reporting_test\\.dart\': Failed assertion: line [0-9]+ pos [0-9]+: \'false\': is not true\\.\n'
@@ -170,7 +172,7 @@ Future<Null> main() async {
     FlutterError.dumpErrorToConsole(new FlutterErrorDetails(
       exception: getAssertionErrorWithoutMessage(),
     ));
-    expect(console.join('\n'), matches('Another exception was thrown: \'[^\']+flutter/test/foundation/error_reporting_test\\.dart\': Failed assertion: line [0-9]+ pos [0-9]+: \'false\': is not true\\.'));
+    expect(sanitizePaths(console.join('\n')), matches('Another exception was thrown: \'[^\']+flutter/test/foundation/error_reporting_test\\.dart\': Failed assertion: line [0-9]+ pos [0-9]+: \'false\': is not true\\.'));
     console.clear();
     FlutterError.resetErrorCount();
   });

packages/flutter/test/foundation/platform_utils.dart

@@ -0,0 +1,12 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:io';
+
+String sanitizePaths(String path) {
+  if (Platform.isWindows) {
+    path = path.replaceAll(new RegExp('\\\\'), '/');
+  }
+  return path;
+}

packages/flutter/test/foundation/stack_trace_test.dart

@@ -5,11 +5,13 @@
 import 'package:flutter/foundation.dart';
 import 'package:test/test.dart';
 
+import 'platform_utils.dart';
+
 void main() {
   // TODO(8128): These tests and the filtering mechanism should be revisited to account for causal async stack traces.
 
   test('FlutterError.defaultStackFilter', () {
-    final List<String> filtered = FlutterError.defaultStackFilter(StackTrace.current.toString().trimRight().split('\n')).toList();
+    final List<String> filtered = FlutterError.defaultStackFilter(sanitizePaths(StackTrace.current.toString()).trimRight().split('\n')).toList();
     expect(filtered.length, greaterThanOrEqualTo(4));
     expect(filtered[0], matches(r'^#0 +main\.<anonymous closure> \(.*stack_trace_test\.dart:[0-9]+:[0-9]+\)$'));
     expect(filtered[1], matches(r'^#1 +Declarer\.test\.<anonymous closure>.<anonymous closure> \(package:test/.+:[0-9]+:[0-9]+\)$'));
@@ -18,7 +20,7 @@ void main() {
   });
 
   test('FlutterError.defaultStackFilter (async test body)', () async {
-    final List<String> filtered = FlutterError.defaultStackFilter(StackTrace.current.toString().trimRight().split('\n')).toList();
+    final List<String> filtered = FlutterError.defaultStackFilter(sanitizePaths(StackTrace.current.toString()).trimRight().split('\n')).toList();
     expect(filtered.length, greaterThanOrEqualTo(3));
     expect(filtered[0], matches(r'^#0 +main\.<anonymous closure> \(.*stack_trace_test\.dart:[0-9]+:[0-9]+\)$'));
     expect(filtered[1], equals('<asynchronous suspension>'));

packages/flutter/test/painting/text_painter_rtl_test.dart

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'dart:io';
+
 import 'package:flutter/foundation.dart';
 import 'package:flutter/painting.dart';
 import 'package:flutter_test/flutter_test.dart';
@@ -284,25 +286,31 @@ void main() {
       painter.getOffsetForCaret(const TextPosition(offset: 1, affinity: TextAffinity.upstream), Rect.zero),
       const Offset(10.0, 0.0),
     );
+
+    Offset offset = (Platform.isWindows) ? new Offset(7.0, 12.0) : new Offset(10.0, 10.0);
     expect( // between A and Alef, before the Alef
       painter.getOffsetForCaret(const TextPosition(offset: 1, affinity: TextAffinity.downstream), Rect.zero),
-      const Offset(10.0, 10.0),
+      offset,
     );
 
+    offset = (Platform.isWindows) ? new Offset(0.0, 12.0) : new Offset(0.0, 10.0);
     expect( // after the Alef
       painter.getOffsetForCaret(const TextPosition(offset: 2, affinity: TextAffinity.upstream), Rect.zero),
-      const Offset(0.0, 10.0),
+      offset,
     );
     expect( // after the Alef
       painter.getOffsetForCaret(const TextPosition(offset: 2, affinity: TextAffinity.downstream), Rect.zero),
-      const Offset(0.0, 10.0),
+      offset,
     );
 
+    TextBox textBox = (Platform.isWindows) ?
+                      new TextBox.fromLTRBD(0.0, 12.0, 7.0, 22.0, TextDirection.rtl) :
+                      new TextBox.fromLTRBD(0.0, 10.0, 10.0, 20.0, TextDirection.rtl);
     expect(
       painter.getBoxesForSelection(const TextSelection(baseOffset: 0, extentOffset: 2)),
-      const <TextBox>[
-        const TextBox.fromLTRBD(0.0,  0.0, 10.0, 10.0, TextDirection.ltr), // A
-        const TextBox.fromLTRBD(0.0, 10.0, 10.0, 20.0, TextDirection.rtl), // Alef
+      <TextBox>[
+        new TextBox.fromLTRBD(0.0,  0.0, 10.0, 10.0, TextDirection.ltr), // A
+        textBox, // Alef
       ],
     );
     expect(
@@ -313,8 +321,8 @@ void main() {
     );
     expect(
       painter.getBoxesForSelection(const TextSelection(baseOffset: 1, extentOffset: 2)),
-      const <TextBox>[
-        const TextBox.fromLTRBD(0.0, 10.0, 10.0, 20.0, TextDirection.rtl), // Alef
+      <TextBox>[
+        textBox, // Alef
       ],
     );
   });

packages/flutter/test/rendering/paragraph_test.dart

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import 'dart:io';
 import 'dart:ui' as ui show TextBox;
 
 import 'package:flutter/rendering.dart';
@@ -67,7 +68,10 @@ void main() {
     );
 
     expect(boxes.any((ui.TextBox box) => box.left == 250 && box.top == 0), isTrue);
-    expect(boxes.any((ui.TextBox box) => box.right == 100 && box.top == 10), isTrue);
+    expect(boxes.any((ui.TextBox box) =>
+      Platform.isWindows ?
+      box.right == 100 && box.top == 13 :
+      box.right == 100 && box.top == 10), isTrue);
   });
 
   test('getWordBoundary control test', () {
@@ -180,7 +184,8 @@ void main() {
     }
 
     layoutAt(null);
-    expect(paragraph.size.height, 130.0);
+    double height = (Platform.isWindows) ? 138.0 : 130.0;
+    expect(paragraph.size.height, height);
 
     layoutAt(1);
     expect(paragraph.size.height, 10.0);
@@ -189,7 +194,8 @@ void main() {
     expect(paragraph.size.height, 20.0);
 
     layoutAt(3);
-    expect(paragraph.size.height, 30.0);
+    height = (Platform.isWindows) ? 34.0 : 30.0;
+    expect(paragraph.size.height, height);
   });
 
   test('changing color does not do layout', () {

packages/flutter_tools/test/commands/test_test.dart

@@ -23,31 +23,37 @@ void main() {
     final String automatedTestsDirectory = fs.path.join('..', '..', 'dev', 'automated_tests');
     final String flutterTestDirectory = fs.path.join(automatedTestsDirectory, 'flutter_test');
 
-    testUsingContext('report nice errors for exceptions thrown within testWidgets()', () async {
-      Cache.flutterRoot = '../..';
-      return _testFile('exception_handling', automatedTestsDirectory, flutterTestDirectory);
-    });
-
-    testUsingContext('report a nice error when a guarded function was called without await', () async {
-      Cache.flutterRoot = '../..';
-      return _testFile('test_async_utils_guarded', automatedTestsDirectory, flutterTestDirectory);
-    });
-
-    testUsingContext('report a nice error when an async function was called without await', () async {
-      Cache.flutterRoot = '../..';
-      return _testFile('test_async_utils_unguarded', automatedTestsDirectory, flutterTestDirectory);
-    });
-
-    testUsingContext('report a nice error when a Ticker is left running', () async {
-      Cache.flutterRoot = '../..';
-      return _testFile('ticker', automatedTestsDirectory, flutterTestDirectory);
-    });
-
-    testUsingContext('report a nice error when a pubspec.yaml is missing a flutter_test dependency', () async {
-      final String missingDependencyTests = fs.path.join('..', '..', 'dev', 'missing_dependency_tests');
-      Cache.flutterRoot = '../..';
-      return _testFile('trivial', missingDependencyTests, missingDependencyTests);
-    });
+    // TODO(bkonyi): These tests all throw exceptions with unicode characters used for formatting,
+    // but the unicode characters aren't being reported correctly on stderr from Process.run. This
+    // seems like it's something to do with how the Dart VM handles Unicode on Windows, so we'll
+    // skip these for now.
+    if (!io.Platform.isWindows) {
+      testUsingContext('report nice errors for exceptions thrown within testWidgets()', () async {
+        Cache.flutterRoot = '../..';
+        return _testFile('exception_handling', automatedTestsDirectory, flutterTestDirectory);
+      });
+
+      testUsingContext('report a nice error when a guarded function was called without await', () async {
+        Cache.flutterRoot = '../..';
+        return _testFile('test_async_utils_guarded', automatedTestsDirectory, flutterTestDirectory);
+      });
+
+      testUsingContext('report a nice error when an async function was called without await', () async {
+        Cache.flutterRoot = '../..';
+        return _testFile('test_async_utils_unguarded', automatedTestsDirectory, flutterTestDirectory);
+      });
+
+      testUsingContext('report a nice error when a Ticker is left running', () async {
+        Cache.flutterRoot = '../..';
+        return _testFile('ticker', automatedTestsDirectory, flutterTestDirectory);
+      });
+
+      testUsingContext('report a nice error when a pubspec.yaml is missing a flutter_test dependency', () async {
+        final String missingDependencyTests = fs.path.join('..', '..', 'dev', 'missing_dependency_tests');
+        Cache.flutterRoot = '../..';
+        return _testFile('trivial', missingDependencyTests, missingDependencyTests);
+      });
+    }
 
     testUsingContext('run a test when its name matches a regexp', () async {
       Cache.flutterRoot = '../..';
@@ -82,7 +88,7 @@ void main() {
       expect(result.exitCode, 0);
     });
 
-  }, skip: io.Platform.isWindows); // TODO(goderbauer): enable when sky_shell is available
+  });
 }
 
 Future<Null> _testFile(String testName, String workingDirectory, String testDirectory) async {