Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring native_assets ios tests out of staging #135015

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Bring native_assets ios tests out of staging #135015

merged 1 commit into from
Sep 19, 2023

Conversation

dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Sep 19, 2023 •
edited

Move test added in #130494 out of staging.

Monitor the CI results of the new shard on the Flutter build dashboard. After 50 consecutive passing builds without any flakes, the flake bot will create a PR to remove the bringup: true parameter from .ci.yaml in the Framework tree. This will allow the test to block the tree, preventing breakages. With this change, the new shard will start running in presubmit automatically, unless specify presubmit: false.

https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard

Umbrella issue:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@dcharkes
Copy link
Contributor Author

@vashworth The test status show up as an empty green square with no summary. Do we need to tweak the tests to make it a fully green square?

image

@vashworth
Copy link
Contributor

@vashworth The test status show up as an empty green square with no summary. Do we need to tweak the tests to make it a fully green square?

image

The hollow green square means it's a bringup/staging test, it'll become a filled green square when it's out of bringup

vashworth
vashworth approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes marked this pull request as ready for review September 19, 2023 15:30
@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2023
@auto-submit auto-submit bot merged commit f246dc7 into master Sep 19, 2023
135 checks passed
@auto-submit auto-submit bot deleted the native-assets-ios-bringup branch September 19, 2023 15:48
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
4bb18bd 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
f1167b4 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
77498c4 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
75e68df 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
4edea5f 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
5a89da2 
…er#135015)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
f047b00 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
f6079d2 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
8483971 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
b8d8c38 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
1598df7 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
19cc583 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
23cbf87 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
422155f 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
005af5d 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
b5409c1 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
f34d849 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
89adb47 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
64ea406 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
0e45221 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
c8fd40c 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
a496484 
…er#135015)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
e643dc7 
…er#135015)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@dcharkes @Mairramer
Bring native_assets ios tests out of staging (flutter#135015)
42dd8c8 
Move test added in flutter#130494 out of staging.

* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios
* https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.staging/Mac_ios%20native_assets_ios_simulator

> Monitor the CI results of the new shard on the [Flutter build dashboard](https://flutter-dashboard.appspot.com/#/build). After 50 consecutive passing builds without any flakes, the flake bot will create a PR to remove the bringup: true parameter from .ci.yaml in the Framework tree. This will allow the test to block the tree, preventing breakages. With this change, the new shard will start running in presubmit automatically, unless specify presubmit: false.

https://github.com/flutter/flutter/wiki/Adding-a-new-Test-Shard#steps-to-add-a-new-framework-test-shard

Umbrella issue:

* flutter#129757
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
f246dc7ae Bring native_assets ios tests out of staging (flutter/flutt…
026042c 
…er#135015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vashworth vashworth vashworth approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dcharkes @vashworth